Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2154)

Unified Diff: tools/gn/target_generator.cc

Issue 1263053003: Add forward_variables_from() and target() to GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/target_generator.cc
diff --git a/tools/gn/target_generator.cc b/tools/gn/target_generator.cc
index 6018147d4c43512b4b5e6da1ad3b1bce0eb18255..cd633f200018d9d5bda1ed6813a7a78d88c0e47a 100644
--- a/tools/gn/target_generator.cc
+++ b/tools/gn/target_generator.cc
@@ -113,8 +113,8 @@ void TargetGenerator::GenerateTarget(Scope* scope,
Target::STATIC_LIBRARY, err);
generator.Run();
} else {
- *err = Err(function_call, "Not a known output type",
- "I am very confused.");
+ *err = Err(function_call, "Not a known target type",
+ "I am very confused by the target type \"" + output_type + "\"");
}
if (err->has_error())

Powered by Google App Engine
This is Rietveld 408576698