Chromium Code Reviews| Index: tools/gn/scope.h |
| diff --git a/tools/gn/scope.h b/tools/gn/scope.h |
| index da3768bc13fa53cd45e29a480ec3602bec53400a..900826c0648484b40b31c2bc6c1ca0dc6d40fd51 100644 |
| --- a/tools/gn/scope.h |
| +++ b/tools/gn/scope.h |
| @@ -68,7 +68,7 @@ class Scope { |
| MergeOptions() |
| : clobber_existing(false), |
| skip_private_vars(false), |
| - mark_used(false) { |
| + mark_dest_used(false) { |
| } |
| // When set, all existing avlues in the destination scope will be |
| @@ -90,7 +90,7 @@ class Scope { |
| // so won't trigger an unused variable warning. You want this when doing an |
| // import, for example, or files that don't need a variable from the .gni |
| // file will throw an error. |
| - bool mark_used; |
| + bool mark_dest_used; |
| }; |
| // Creates an empty toplevel scope. |
| @@ -155,6 +155,14 @@ class Scope { |
| Value* GetValueForcedToCurrentScope(const base::StringPiece& ident, |
| const ParseNode* set_node); |
| + // Returns the StringPiece used to identify the value. This string piece |
| + // will have the same contents as "ident" passed in, but may point to a |
| + // different underlying buffer. This is useful because this StringPiece is |
| + // static and won't be deleted for the life of the program, so it can be used |
| + // as keys in places that may outlive a temporary. It will return an empty |
| + // string for programatic and nonexistant values. |
|
Dirk Pranke
2015/08/03 21:12:24
still have the "programmatic" typo
|
| + base::StringPiece GetStorageKey(const base::StringPiece& ident) const; |
| + |
| // The set_node indicates the statement that caused the set, for displaying |
| // errors later. Returns a pointer to the value in the current scope (a copy |
| // is made for storage). |
| @@ -179,6 +187,7 @@ class Scope { |
| // Marks the given identifier as (un)used in the current scope. |
| void MarkUsed(const base::StringPiece& ident); |
| + void MarkAllUsed(); |
| void MarkUnused(const base::StringPiece& ident); |
| // Checks to see if the scope has a var set that hasn't been used. This is |