Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1263033003: Make PositionAlgorithm<Strategy>::next() to use Strategy::index() (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
tkent, yoichio, hajimehoshi
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make PositionAlgorithm<Strategy>::next() to use Strategy::index() This patch changes |PositionAlgorithm<Strategy>::next()| to use |Strategy::index(Node&)| instead of |Node::nodexIndex()| to compute offset of node in parent node with DOM tree or composed tree base on |Strategy| template parameter for correct behavior in |PositionInComposedTree|. This patch is a preparation of templatizing |VisiblePosition|. BUG=513568 TEST=PositionTest.NextNodeIndex Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199920

Patch Set 1 : 2015-08-03T16:32:43 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M Source/core/dom/Position.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/PositionTest.cpp View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-03 09:05:21 UTC) #2
hajimehoshi
lgtm
5 years, 4 months ago (2015-08-03 09:52:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263033003/1
5 years, 4 months ago (2015-08-03 09:52:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/38966)
5 years, 4 months ago (2015-08-03 09:57:28 UTC) #7
tkent
lgtm
5 years, 4 months ago (2015-08-03 22:51:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263033003/1
5 years, 4 months ago (2015-08-03 22:52:24 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 22:55:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199920

Powered by Google App Engine
This is Rietveld 408576698