Files.app: Treats HTTP_FORBIDDEN (403) as temporary error on authentication.

Files.app: Treats HTTP_FORBIDDEN (403) as temporary error on authentication.

Sometimes the auth server returns '403 Rate Limit Exceeded' but it is treated as a permanent error and makes Files.app offline-mode. This patch makes '403' treated as a temporary error.

BUG=180830
TEST=Repeat logging-in and opening Files.app 20 times, and confirms the error is not happen.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189787

[yoshiki, 2013-03-11 09:55:32]

@kinaba: could you take a look? Thanks.

[kinaba, 2013-03-11 09:57:32]

lgtm for c/b/google_apis.

[yoshiki, 2013-03-12 00:57:21]

+zelidrag
Could you take a look at google_apis/gaia/oauth2_access_token_fetcher.cc?

[yoshiki, 2013-03-18 15:41:24]

@zel: ping?

[zel, 2013-03-18 16:15:05]

lgtm

[commit-bot: I haz the power, 2013-03-18 16:15:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/12630010/2001

[commit-bot: I haz the power, 2013-03-18 19:18:40]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-03-19 03:19:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/12630010/20001

[commit-bot: I haz the power, 2013-03-19 03:28:01]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[commit-bot: I haz the power, 2013-03-19 03:31:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/12630010/21003

[commit-bot: I haz the power, 2013-03-19 04:42:30]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-03-20 10:03:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/12630010/36001

[commit-bot: I haz the power, 2013-03-20 11:05:20]

Retried try job too often on linux_rel for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[yoshiki, 2013-03-21 16:39:37]

+joaodasilva: Could you take a look at login_utils_browsertest.cc? Thanks,

[Joao da Silva, 2013-03-21 17:00:19]

lgtm

Thanks for updating the test!

[commit-bot: I haz the power, 2013-03-21 17:33:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/12630010/48001

[yoshiki, 2013-03-22 09:58:17]

Committed patchset #6 manually as r189787 (presubmit successful).