Files.app: Treats HTTP_FORBIDDEN (403) as temporary error on authentication.

chrome/browser/google_apis/auth_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/google_apis/auth_service.h"
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 22 matching lines @@
 
 namespace google_apis {
 
 namespace {
 
 // Used for success ratio histograms. 0 for failure, 1 for success,
 // 2 for no connection (likely offline).
 const int kSuccessRatioHistogramFailure = 0;
 const int kSuccessRatioHistogramSuccess = 1;
 const int kSuccessRatioHistogramNoConnection = 2;
-const int kSuccessRatioHistogramMaxValue = 3;  // The max value is exclusive.
+const int kSuccessRatioHistogramTemporaryFailure = 3;
+const int kSuccessRatioHistogramMaxValue = 4;  // The max value is exclusive.
 
 }  // namespace
 
 // OAuth2 authorization token retrieval operation.
 class AuthOperation : public OperationRegistry::Operation,
                       public OAuth2AccessTokenConsumer {
  public:
   AuthOperation(OperationRegistry* registry,
                 net::URLRequestContextGetter* url_request_context_getter,
                 const AuthStatusCallback& callback,
@@ skipping 75 matching lines @@
                << error.ToString();
 
   // There are many ways to fail, but if the failure is due to connection,
   // it's likely that the device is off-line. We treat the error differently
   // so that the file manager works while off-line.
   if (error.state() == GoogleServiceAuthError::CONNECTION_FAILED) {
     UMA_HISTOGRAM_ENUMERATION("GData.AuthSuccess",
                               kSuccessRatioHistogramNoConnection,
                               kSuccessRatioHistogramMaxValue);
     callback_.Run(GDATA_NO_CONNECTION, std::string());
+  } else if (error.state() == GoogleServiceAuthError::SERVICE_UNAVAILABLE) {
+    // Temporary auth error.
+    UMA_HISTOGRAM_ENUMERATION("GData.AuthSuccess",
+                              kSuccessRatioHistogramTemporaryFailure,
+                              kSuccessRatioHistogramMaxValue);
+    callback_.Run(HTTP_FORBIDDEN, std::string());
   } else {
+    // Permanent auth error.
     UMA_HISTOGRAM_ENUMERATION("GData.AuthSuccess",
                               kSuccessRatioHistogramFailure,
                               kSuccessRatioHistogramMaxValue);
     callback_.Run(HTTP_UNAUTHORIZED, std::string());
   }
   NotifyFinish(OPERATION_FAILED);
 }
 
 void AuthService::Initialize(Profile* profile) {
   profile_ = profile;
@@ skipping 139 matching lines @@
 #endif  // OS_CHROMEOS
 
   // Authentication cannot be done with the incognito mode profile.
   if (profile->IsOffTheRecord())
     return false;
 
   return true;
 }
 
 }  // namespace google_apis