components/test_runner/web_test_delegate.h - Issue 1262893006: Enable testing NotificationEvent.action

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/web_test_delegate.h

Issue 1262893006: Enable testing NotificationEvent.action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@click_actions

Patch Set: TestRunnerBindings::SimulateWebNotificationClick throws for non int index Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/test_runner/web_test_delegate.h

diff --git a/components/test_runner/web_test_delegate.h b/components/test_runner/web_test_delegate.h

index a1bc3c38d6291d4d52f9a24e976099f87cd51d0a..cbef50ab8b27e5436ab49d1171145b1aee4902e5 100644

--- a/components/test_runner/web_test_delegate.h

+++ b/components/test_runner/web_test_delegate.h

@@ -149,7 +149,8 @@ class WebTestDelegate {

virtual void SetDatabaseQuota(int quota) = 0;

// Controls Web Notifications.

- virtual void SimulateWebNotificationClick(const std::string& title) = 0;

+ virtual void SimulateWebNotificationClick(const std::string& title,

+ int action_index) = 0;

// Controls the device scale factor of the main WebView for hidpi tests.

virtual void SetDeviceScaleFactor(float factor) = 0;