Enable testing NotificationEvent.action

components/test_runner/test_runner.cc

Index: components/test_runner/test_runner.cc
diff --git a/components/test_runner/test_runner.cc b/components/test_runner/test_runner.cc
index 1f156c68436a6441793b7a91523f0b2dc1b5de53..53db853838e1e197ba343056bc72c99b6ca54577 100644
--- a/components/test_runner/test_runner.cc
+++ b/components/test_runner/test_runner.cc
@@ -273,7 +273,7 @@ class TestRunnerBindings : public gin::Wrappable<TestRunnerBindings> {
                        v8::Local<v8::Function> callback);
   void SetPOSIXLocale(const std::string& locale);
   void SetMIDIAccessorResult(bool result);
-  void SimulateWebNotificationClick(const std::string& title);
+  void SimulateWebNotificationClick(gin::Arguments* args);
   void AddMockSpeechRecognitionResult(const std::string& transcript,
                                       double confidence);
   void SetMockSpeechRecognitionError(const std::string& error,
@@ -1343,10 +1343,17 @@ void TestRunnerBindings::SetMIDIAccessorResult(bool result) {
     runner_->SetMIDIAccessorResult(result);
 }
 
-void TestRunnerBindings::SimulateWebNotificationClick(
-    const std::string& title) {
-  if (runner_)
-    runner_->SimulateWebNotificationClick(title);
+void TestRunnerBindings::SimulateWebNotificationClick(gin::Arguments* args) {
+  if (!runner_)
+    return;
+  std::string title;
+  int action_index = -1;
+  if (!args->GetNext(&title) ||
+      !args->PeekNext().IsEmpty() && !args->GetNext(&action_index)) {

[Peter Beverloo, 2015/08/07 00:11:28]

nit: you could rewrite this statement to be easier to read (negations don't help
- hi TotT!)

==========
if (args->GetNext(&title) &&
    (args->PeekNext().IsEmpty() || args->GetNext(&action_index)))
  runner_->Simultate..

args->ThrowError();
==========

You should consider simply making it required in the call to
SimultateWebNotificationClick, i.e. have this code now, then update all the
tests, then change this away from using gin::Arguments* again.

[johnme, 2015/08/07 07:09:54]

Done.
Acknowledged.

+    args->ThrowError();
+    return;
+  }
+  runner_->SimulateWebNotificationClick(title, action_index);
 }
 
 void TestRunnerBindings::AddMockSpeechRecognitionResult(
@@ -2854,8 +2861,9 @@ void TestRunner::SetMIDIAccessorResult(bool result) {
   midi_accessor_result_ = result;
 }
 
-void TestRunner::SimulateWebNotificationClick(const std::string& title) {
-  delegate_->SimulateWebNotificationClick(title);
+void TestRunner::SimulateWebNotificationClick(const std::string& title,
+                                              int action_index) {
+  delegate_->SimulateWebNotificationClick(title, action_index);
 }
 
 void TestRunner::AddMockSpeechRecognitionResult(const std::string& transcript,