Issue 1262883003: Revert of Added affiliation IDs for the new affiliation determination.

Issue 1262883003: Revert of Added affiliation IDs for the new affiliation determination. (Closed)

Created:
5 years, 4 months ago by dvh

Modified:
5 years, 4 months ago

Reviewers:
Dmitry Polukhin, Andrew T Wilson (Slow), Mattias Nissler (ping if slow), peletskyi

CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Added affiliation IDs for the new affiliation determination. (patchset #13 id:240001 of https://codereview.chromium.org/1266563002/) Reason for revert: Breaking the following build: Linux ChromiumOS Tests (1) Build #6802 https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/6802 Original issue's description: > Added affiliation IDs, that in future will be used to determine user affiliation to the device. Added unit-test as well. > > BUG=491210 > > Committed: https://crrev.com/2bd626caac141ef01a2396d232fb6391d23b1e79 > Cr-Commit-Position: refs/heads/master@{#341159} TBR=mnissler@chromium.org,atwilson@chromium.org,dpolukhin@chromium.org,peletskyi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=491210 Committed: https://crrev.com/2764561f205fa201f971477ae16405236f1c8b16 Cr-Commit-Position: refs/heads/master@{#341170}

Patch Set 1 #

Created: 5 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -318 lines)			Patch
D	chrome/browser/chromeos/login/users/affiliation.h	View	1 chunk	+0 lines, -33 lines	0 comments	Download
D	chrome/browser/chromeos/login/users/affiliation.cc	View	1 chunk	+0 lines, -58 lines	0 comments	Download
D	chrome/browser/chromeos/login/users/affiliation_unittest.cc	View	1 chunk	+0 lines, -108 lines	0 comments	Download
M	chrome/browser/chromeos/login/users/chrome_user_manager.h	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/login/users/chrome_user_manager_impl.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc	View	3 chunks	+0 lines, -18 lines	0 comments	Download
M	chrome/browser/chromeos/login/users/mock_user_manager.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h	View	3 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc	View	2 chunks	+1 line, -15 lines	0 comments	Download
M	chrome/browser/chromeos/policy/enterprise_install_attributes.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/policy/enterprise_install_attributes.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc	View	3 chunks	+0 lines, -20 lines	0 comments	Download
M	chrome/browser/policy/test/policy_testserver.py	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	chrome/chrome_browser_chromeos.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/policy/proto/device_management_backend.proto	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	components/user_manager/user.h	View	3 chunks	+0 lines, -10 lines	0 comments	Download
M	components/user_manager/user.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dvh

Created Revert of Added affiliation IDs for the new affiliation determination.

5 years, 4 months ago (2015-07-30 19:29:17 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262883003/1

5 years, 4 months ago (2015-07-30 19:30:00 UTC) #2

commit-bot: I haz the power

5 years, 4 months ago (2015-07-30 19:32:41 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2764561f205fa201f971477ae16405236f1c8b16
Cr-Commit-Position: refs/heads/master@{#341170}

Expand Messages | Collapse Messages