chrome/common/safe_browsing/csd.proto - Issue 1262753002: [SafeBrowsing] Send pings for Zip files that contain other archives.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/safe_browsing/csd.proto

Issue 1262753002: [SafeBrowsing] Send pings for Zip files that contain other archives. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address asvitkine comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/chrome_utility_messages.h ('k') | chrome/common/safe_browsing/download_protection_util.h » ('j') | chrome/common/safe_browsing/download_protection_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/safe_browsing/csd.proto

diff --git a/chrome/common/safe_browsing/csd.proto b/chrome/common/safe_browsing/csd.proto

index b198718f3971404e7b84f4cd270f0d93c137b432..5243dc9bf1a306670462f08eb89d6b38f423cac4 100644

--- a/chrome/common/safe_browsing/csd.proto

+++ b/chrome/common/safe_browsing/csd.proto

@@ -245,7 +245,8 @@ message ClientDownloadRequest {

ANDROID_APK = 2; // .apk files.

// .zip files containing one of the other executable types.

ZIPPED_EXECUTABLE = 3;

- MAC_EXECUTABLE = 4; // .dmg, .pkg, etc.

+ MAC_EXECUTABLE = 4; // .dmg, .pkg, etc.

+ ZIPPED_ARCHIVE = 5; // .zip file containing another archive.

palmer 2015/07/31 22:48:18 |NESTED_ARCHIVE| is more explanatory, IMO.

asanka 2015/08/02 03:43:32 We are currently looking just at zip files, but I

}

optional DownloadType download_type = 10 [default = WIN_EXECUTABLE];