Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: chrome/common/safe_browsing/csd.proto

Issue 1262753002: [SafeBrowsing] Send pings for Zip files that contain other archives. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address asvitkine comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Client side phishing and malware detection request and response 5 // Client side phishing and malware detection request and response
6 // protocol buffers. Those protocol messages should be kept in sync 6 // protocol buffers. Those protocol messages should be kept in sync
7 // with the server implementation. 7 // with the server implementation.
8 // 8 //
9 // If you want to change this protocol definition or you have questions 9 // If you want to change this protocol definition or you have questions
10 // regarding its format please contact chrome-anti-phishing@googlegroups.com. 10 // regarding its format please contact chrome-anti-phishing@googlegroups.com.
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 optional string file_basename = 9; 238 optional string file_basename = 9;
239 239
240 // Starting with Chrome M19 we're also sending back pings for Chrome 240 // Starting with Chrome M19 we're also sending back pings for Chrome
241 // extensions that get downloaded by users. 241 // extensions that get downloaded by users.
242 enum DownloadType { 242 enum DownloadType {
243 WIN_EXECUTABLE = 0; // Currently all .exe, .cab and .msi files. 243 WIN_EXECUTABLE = 0; // Currently all .exe, .cab and .msi files.
244 CHROME_EXTENSION = 1; // .crx files. 244 CHROME_EXTENSION = 1; // .crx files.
245 ANDROID_APK = 2; // .apk files. 245 ANDROID_APK = 2; // .apk files.
246 // .zip files containing one of the other executable types. 246 // .zip files containing one of the other executable types.
247 ZIPPED_EXECUTABLE = 3; 247 ZIPPED_EXECUTABLE = 3;
248 MAC_EXECUTABLE = 4; // .dmg, .pkg, etc. 248 MAC_EXECUTABLE = 4; // .dmg, .pkg, etc.
249 ZIPPED_ARCHIVE = 5; // .zip file containing another archive.
palmer 2015/07/31 22:48:18 |NESTED_ARCHIVE| is more explanatory, IMO.
asanka 2015/08/02 03:43:32 We are currently looking just at zip files, but I
249 } 250 }
250 optional DownloadType download_type = 10 [default = WIN_EXECUTABLE]; 251 optional DownloadType download_type = 10 [default = WIN_EXECUTABLE];
251 252
252 // Locale of the device, eg en, en_US. 253 // Locale of the device, eg en, en_US.
253 optional string locale = 11; 254 optional string locale = 11;
254 255
255 message PEImageHeaders { 256 message PEImageHeaders {
256 // IMAGE_DOS_HEADER. 257 // IMAGE_DOS_HEADER.
257 optional bytes dos_header = 1; 258 optional bytes dos_header = 1;
258 // IMAGE_FILE_HEADER. 259 // IMAGE_FILE_HEADER.
(...skipping 286 matching lines...) Expand 10 before | Expand all | Expand 10 after
545 message EnvironmentRequest { optional int32 dll_index = 1; } 546 message EnvironmentRequest { optional int32 dll_index = 1; }
546 547
547 repeated EnvironmentRequest environment_requests = 3; 548 repeated EnvironmentRequest environment_requests = 3;
548 } 549 }
549 550
550 message DownloadMetadata { 551 message DownloadMetadata {
551 optional uint32 download_id = 1; 552 optional uint32 download_id = 1;
552 553
553 optional ClientIncidentReport.DownloadDetails download = 2; 554 optional ClientIncidentReport.DownloadDetails download = 2;
554 } 555 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698