Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1262723006: Merge to XFA: Kill IFX_FontMapper (Closed)

Created:
5 years, 4 months ago by Tom Sepez
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Kill IFX_FontMapper (cherry picked from commit 01fa1efb228acdcf5250804c670107133668e4b2) Orignal Review URL: https://codereview.chromium.org/1259123005 . conflicts: core/include/fxge/fx_font.h core/src/fxge/ge/fx_ge_fontmap.cpp R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d1e6a3f6d95e37cae3caf40bca0a0aacf8d0e223

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -57 lines) Patch
M core/include/fxge/fx_font.h View 5 chunks +12 lines, -20 lines 0 comments Download
M core/include/fxge/fx_ge.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fxge/apple/apple_int.h View 1 chunk +3 lines, -9 lines 0 comments Download
M core/src/fxge/ge/fx_ge.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 3 chunks +9 lines, -22 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
Lei, some manual merges.
5 years, 4 months ago (2015-07-31 21:17:21 UTC) #1
Lei Zhang
lgtm
5 years, 4 months ago (2015-07-31 21:21:55 UTC) #2
Tom Sepez
5 years, 4 months ago (2015-07-31 21:28:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d1e6a3f6d95e37cae3caf40bca0a0aacf8d0e223 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698