Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1262683006: Componentize variations_url_constants.* (Closed)

Created:
5 years, 4 months ago by blundell
Modified:
5 years, 4 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize variations_url_constants.* Part of the ongoing effort to decouple the iOS port from //chrome/browser/metrics. BUG=516663 Committed: https://crrev.com/76fe868c6e571aa066093638b537e496ef63908b Cr-Commit-Position: refs/heads/master@{#341880}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -34 lines) Patch
M chrome/browser/metrics/variations/variations_service.cc View 1 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/metrics/variations/variations_url_constants.h View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/browser/metrics/variations/variations_url_constants.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/variations.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/variations/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/variations/variations_url_constants.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/variations/variations_url_constants.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (9 generated)
blundell
5 years, 4 months ago (2015-08-04 14:41:12 UTC) #2
blundell
(BTW, my intention is to defer changing namespace until the end to avoid churn on ...
5 years, 4 months ago (2015-08-04 14:42:04 UTC) #3
Alexei Svitkine (slow)
lgtm
5 years, 4 months ago (2015-08-04 15:08:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262683006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262683006/1
5 years, 4 months ago (2015-08-04 15:19:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/94588)
5 years, 4 months ago (2015-08-04 15:23:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262683006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262683006/20001
5 years, 4 months ago (2015-08-04 15:51:44 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/38066)
5 years, 4 months ago (2015-08-04 16:07:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262683006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262683006/20001
5 years, 4 months ago (2015-08-05 08:14:35 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/88803)
5 years, 4 months ago (2015-08-05 10:12:44 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262683006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262683006/20001
5 years, 4 months ago (2015-08-05 10:23:43 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-05 10:59:03 UTC) #20
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 11:00:40 UTC) #21
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/76fe868c6e571aa066093638b537e496ef63908b
Cr-Commit-Position: refs/heads/master@{#341880}

Powered by Google App Engine
This is Rietveld 408576698