Source/web/AssociatedURLLoaderTest.cpp - Issue 1262593004: Prevent ThreadableLoaderClient methods from being called after failure notification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/AssociatedURLLoaderTest.cpp

Issue 1262593004: Prevent ThreadableLoaderClient methods from being called after failure notification (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Don't clear the resource in didFinishLoading Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/AssociatedURLLoaderTest.cpp

diff --git a/Source/web/AssociatedURLLoaderTest.cpp b/Source/web/AssociatedURLLoaderTest.cpp

index b72896aebec6be92d3b033336ca5aea0c8a837f7..07000f39c3665d78f35a342a42f9305de8535161 100644

--- a/Source/web/AssociatedURLLoaderTest.cpp

+++ b/Source/web/AssociatedURLLoaderTest.cpp

@@ -548,7 +548,7 @@ TEST_F(AssociatedURLLoaderTest, RedirectCrossOriginWithAccessControlFailure)

// We should get a notification about access control check failure.

EXPECT_FALSE(m_willSendRequest);

EXPECT_FALSE(m_didReceiveResponse);

- EXPECT_TRUE(m_didReceiveData);

+ EXPECT_FALSE(m_didReceiveData);

EXPECT_TRUE(m_didFail);

}

« Source/core/page/EventSource.cpp ('K') | « Source/core/page/EventSource.cpp ('k') | no next file » | no next file with comments »