Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1179)

Unified Diff: Source/core/page/EventSource.cpp

Issue 1262593004: Prevent ThreadableLoaderClient methods from being called after failure notification (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Don't clear the resource in didFinishLoading Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/EventSource.cpp
diff --git a/Source/core/page/EventSource.cpp b/Source/core/page/EventSource.cpp
index 8f893ca29f11ef93ffa3666fd82eee0ac7adba90..6eeffb7a330661ff2b44f819f9a65fc36e7b54af 100644
--- a/Source/core/page/EventSource.cpp
+++ b/Source/core/page/EventSource.cpp
@@ -315,13 +315,10 @@ void EventSource::abortConnectionAttempt()
{
ASSERT(m_state == CONNECTING);
- if (m_requestInFlight) {
- m_loader->cancel();
hiroshige 2015/08/03 13:22:19 What is the reason for omitting cancel() in this C
tyoshino (SeeGerritForStatus) 2015/08/04 08:32:05 With the main change of this CL, the loader stops
- } else {
- m_state = CLOSED;
- }
+ m_loader = nullptr;
+ m_state = CLOSED;
+ networkRequestEnded();
- ASSERT(m_state == CLOSED);
dispatchEvent(Event::create(EventTypeNames::error));
}

Powered by Google App Engine
This is Rietveld 408576698