content/browser/frame_host/render_frame_host_manager.h - Issue 1262563003: Subframes in inner WebContents should not create proxies in process of outer WebContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager.h

Issue 1262563003: Subframes in inner WebContents should not create proxies in process of outer WebContents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments from lfg@ Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/cross_process_frame_connector.cc ('k') | content/browser/frame_host/render_frame_host_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_manager.h

diff --git a/content/browser/frame_host/render_frame_host_manager.h b/content/browser/frame_host/render_frame_host_manager.h

index 3cfcab13fb76f4c5d0c9fac377d9287db6340130..4a5b85e5d9548fff48abca70682473da53afeea9 100644

--- a/content/browser/frame_host/render_frame_host_manager.h

+++ b/content/browser/frame_host/render_frame_host_manager.h

@@ -233,10 +233,8 @@ class CONTENT_EXPORT RenderFrameHostManager {

// there is no current one.

RenderWidgetHostView* GetRenderWidgetHostView() const;

- // Returns whether this manager belongs to a FrameTreeNode that is a main

- // frame in an inner WebContents.

- // TODO(lazyboy): Make this work correctly for subframes inside inner

- // WebContents too.

+ // Returns whether this manager belongs to a FrameTreeNode that belongs to an

+ // inner WebContents.

bool ForInnerDelegate();

// Returns the RenderWidgetHost of the outer WebContents (if any) that can be