content/browser/frame_host/cross_process_frame_connector.cc - Issue 1262563003: Subframes in inner WebContents should not create proxies in process of outer WebContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/cross_process_frame_connector.cc

Issue 1262563003: Subframes in inner WebContents should not create proxies in process of outer WebContents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments from lfg@ Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/platform_apps/web_view/shim/parent_frame.html ('k') | content/browser/frame_host/render_frame_host_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/cross_process_frame_connector.cc

diff --git a/content/browser/frame_host/cross_process_frame_connector.cc b/content/browser/frame_host/cross_process_frame_connector.cc

index 8c473e2cba2a1c9740758f1aec2204b254a3f4aa..d9da44ad29f6092e584f5f529186379d572b20ed 100644

--- a/content/browser/frame_host/cross_process_frame_connector.cc

+++ b/content/browser/frame_host/cross_process_frame_connector.cc

@@ -152,6 +152,7 @@ void CrossProcessFrameConnector::GetScreenInfo(blink::WebScreenInfo* results) {

if (frame_proxy_in_parent_renderer_->frame_tree_node()

->render_manager()

->ForInnerDelegate()) {

+ DCHECK(frame_proxy_in_parent_renderer_->frame_tree_node()->IsMainFrame());

return;

}