Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 126253002: Fix step and build time output. (Closed)

Created:
6 years, 11 months ago by shatch
Modified:
6 years, 11 months ago
Reviewers:
tonyg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix perf and build time output. Previously, times reported were a lot smaller than they really were since we weren't filtering out skipped steps and they were getting averaged in with actual build/run times. This is just a fix in output, no changes to logic. BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M tools/bisect-perf-regression.py View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
shatch
6 years, 11 months ago (2014-01-07 19:06:55 UTC) #1
tonyg
lgtm
6 years, 11 months ago (2014-01-07 19:17:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/126253002/1
6 years, 11 months ago (2014-01-07 19:34:41 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 19:53:38 UTC) #4
Message was sent while issue was closed.
Change committed as 243369

Powered by Google App Engine
This is Rietveld 408576698