Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: tools/bisect-perf-regression.py

Issue 126253002: Fix step and build time output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bisect-perf-regression.py
diff --git a/tools/bisect-perf-regression.py b/tools/bisect-perf-regression.py
index 50966c18f404847cecf3949d1214cf8730858992..00460681718033c60b115527068d4d8eb66896ec 100755
--- a/tools/bisect-perf-regression.py
+++ b/tools/bisect-perf-regression.py
@@ -1623,7 +1623,7 @@ class BisectPerformanceMetrics(object):
if not external_revisions is None:
return (results[0], results[1], external_revisions,
- time.time() - after_build_time, time.time() -
+ time.time() - after_build_time, after_build_time -
start_build_time)
else:
return ('Failed to parse DEPS file for external revisions.',
@@ -2379,9 +2379,10 @@ class BisectPerformanceMetrics(object):
step_build_time_avg = 0.0
step_count = 0.0
for _, current_data in revision_data_sorted:
- step_perf_time_avg += current_data['perf_time']
- step_build_time_avg += current_data['build_time']
- step_count += 1
+ if current_data['value']:
+ step_perf_time_avg += current_data['perf_time']
+ step_build_time_avg += current_data['build_time']
+ step_count += 1
if step_count:
step_perf_time_avg = step_perf_time_avg / step_count
step_build_time_avg = step_build_time_avg / step_count
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698