Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1262513002: Use vectorized icon for default extensions icons (Closed)

Created:
5 years, 4 months ago by Evan Stade
Modified:
5 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use vectorized icon for default extensions icons BUG=505953 Committed: https://crrev.com/e77f0e43314897c3039d798fa58991b060920361 Cr-Commit-Position: refs/heads/master@{#341007}

Patch Set 1 #

Patch Set 2 : v1 #

Patch Set 3 : self review #

Patch Set 4 : self review II #

Patch Set 5 : remove resource #

Total comments: 1

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -9 lines) Patch
D chrome/app/theme/default_100_percent/common/extensions_section.png View 1 2 3 4 Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/extensions_section.png View 1 2 3 4 Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_icon_manager.cc View 1 2 2 chunks +13 lines, -3 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/website_settings/permissions_bubble_view.cc View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A ui/gfx/vector_icons/extension.icon View 1 chunk +31 lines, -0 lines 0 comments Download
M ui/native_theme/common_theme.cc View 1 2 3 2 chunks +8 lines, -2 lines 0 comments Download
M ui/native_theme/native_theme.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Evan Stade
Sebastien approved screenshots via email.
5 years, 4 months ago (2015-07-27 23:33:50 UTC) #2
Evan Stade
https://codereview.chromium.org/1262513002/diff/80001/chrome/browser/extensions/extension_icon_manager.cc File chrome/browser/extensions/extension_icon_manager.cc (right): https://codereview.chromium.org/1262513002/diff/80001/chrome/browser/extensions/extension_icon_manager.cc#newcode118 chrome/browser/extensions/extension_icon_manager.cc:118: // TODO(estade): use correct scale factor instead of 1x. ...
5 years, 4 months ago (2015-07-27 23:34:21 UTC) #3
sky
LGTM
5 years, 4 months ago (2015-07-27 23:52:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262513002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262513002/80001
5 years, 4 months ago (2015-07-28 16:23:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/21496)
5 years, 4 months ago (2015-07-28 17:54:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262513002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262513002/100001
5 years, 4 months ago (2015-07-29 20:59:50 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/79027) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-07-29 21:02:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262513002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262513002/120001
5 years, 4 months ago (2015-07-29 21:17:22 UTC) #16
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 4 months ago (2015-07-29 23:20:31 UTC) #17
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 23:21:58 UTC) #18
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/e77f0e43314897c3039d798fa58991b060920361
Cr-Commit-Position: refs/heads/master@{#341007}

Powered by Google App Engine
This is Rietveld 408576698