Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

Issue 1262513002: Use vectorized icon for default extensions icons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc ('k') | ui/gfx/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
diff --git a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
index 3f614ba578f67e0bb7a00cefb39b0fa9c902ed73..81a334f4871a344de7ed617f465815955d447769 100644
--- a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
+++ b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
@@ -25,6 +25,8 @@
#include "ui/base/resource/resource_bundle.h"
#include "ui/gfx/paint_vector_icon.h"
#include "ui/gfx/text_constants.h"
+#include "ui/native_theme/common_theme.h"
+#include "ui/native_theme/native_theme.h"
#include "ui/views/bubble/bubble_delegate.h"
#include "ui/views/bubble/bubble_frame_view.h"
#include "ui/views/controls/button/checkbox.h"
@@ -244,9 +246,10 @@ PermissionsBubbleDelegateView::PermissionsBubbleDelegateView(
views::ImageView* icon = new views::ImageView();
gfx::VectorIconId vector_id = requests[index]->GetVectorIconId();
if (vector_id != gfx::VectorIconId::VECTOR_ICON_NONE) {
- // TODO(estade): move this color to a shared location?
- icon->SetImage(gfx::CreateVectorIcon(vector_id, kIconSize,
- SkColorSetRGB(0x5A, 0x5A, 0x5A)));
+ SkColor grey;
+ ui::CommonThemeGetSystemColor(ui::NativeTheme::kColorId_ChromeIconGrey,
+ &grey);
+ icon->SetImage(gfx::CreateVectorIcon(vector_id, kIconSize, grey));
} else {
icon->SetImage(bundle.GetImageSkiaNamed(requests.at(index)->GetIconID()));
icon->SetImageSize(gfx::Size(kIconSize, kIconSize));
« no previous file with comments | « chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc ('k') | ui/gfx/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698