Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1262503006: Reducing noise in memory measurement in memory.memory_health_plan benchmark (Closed)

Created:
5 years, 4 months ago by ssid
Modified:
5 years, 4 months ago
Reviewers:
perezju, Sami
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@skia_v2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reducing noise in memory measurement in memory.memory_health_plan benchmark The memory.memory_health_plan benchmark runs with tracing enabled with all categories. This causes noise in the memory measurements since the tracing itself uses memory. This CL removes the categories enabled by default and includes only the necessary ones. BUG=486009 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Patch Set 1 #

Patch Set 2 : Removing wrong dependency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/perf/benchmarks/memory_health_plan.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
ssid
PTAL, Thanks
5 years, 4 months ago (2015-07-29 13:01:35 UTC) #2
Sami
Good find. lgtm.
5 years, 4 months ago (2015-07-29 13:14:32 UTC) #3
ssid
+perezju FYI.
5 years, 4 months ago (2015-07-29 19:41:06 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 1260753004 Patch 20001). Please resolve the dependency and ...
5 years, 4 months ago (2015-07-29 19:42:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262503006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262503006/20001
5 years, 4 months ago (2015-07-31 12:33:00 UTC) #11
ssid
5 years, 4 months ago (2015-07-31 12:35:37 UTC) #13
On 2015/07/31 12:33:00, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1262503006/20001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1262503006/20001

Closing: changes added to by crrev.com/1271493002.

Powered by Google App Engine
This is Rietveld 408576698