tools/perf/benchmarks/memory_health_plan.py - Issue 1262503006: Reducing noise in memory measurement in memory.memory_health_plan benchmark

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/memory_health_plan.py

Issue 1262503006: Reducing noise in memory measurement in memory.memory_health_plan benchmark (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@skia_v2

Patch Set: Removing wrong dependency. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/memory_health_plan.py

diff --git a/tools/perf/benchmarks/memory_health_plan.py b/tools/perf/benchmarks/memory_health_plan.py

index c4c8750d0d8baec9a04df280a3cdb104d6255de5..25a7e525fb21fbc136c84feb431e657b9f37237d 100644

--- a/tools/perf/benchmarks/memory_health_plan.py

+++ b/tools/perf/benchmarks/memory_health_plan.py

@@ -23,8 +23,9 @@ class MemoryHealthPlan(perf_benchmark.PerfBenchmark):

page_set = page_sets.MemoryHealthStory

def CreateTimelineBasedMeasurementOptions(self):

+ # blink.console adds the timeline markers used for mapping threads to tabs.

trace_memory = tracing_category_filter.TracingCategoryFilter(

- filter_string='disabled-by-default-memory-infra')

+ filter_string='-*,blink.console,disabled-by-default-memory-infra')

return timeline_based_measurement.Options(overhead_level=trace_memory)

@classmethod

« no previous file with comments | « no previous file | no next file » | no next file with comments »