Issue 1262453004: Add a handler for enabled/disabling assist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1262453004: Add a handler for enabled/disabling assist. (Closed)

Created:
5 years, 4 months ago by Ted C

Modified:
5 years, 4 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2454

Target Ref:
refs/pending/branch-heads/2454

Project:
chromium

Visibility:
Public.

Add a handler for enabled/disabling assist. This disables assist if showing an incognito tab or if in a tab switcher showing icognito tabs. BUG=497258 Review URL: https://codereview.chromium.org/1255973004 Cr-Commit-Position: refs/heads/master@{#340382} Committed: https://chromium.googlesource.com/chromium/src/+/18d14d2c5ee9c34127631d54ff023f4d2c2b6236

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+166 lines, -8 lines)			Patch
A	chrome/android/java/src/org/chromium/chrome/browser/AssistStatusHandler.java	View	1 chunk	+105 lines, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java	View	4 chunks	+28 lines, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java	View	5 chunks	+33 lines, -8 lines	0 comments	Download

Total messages: 1 (0 generated)

Ted C

5 years, 4 months ago (2015-07-27 20:44:51 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
18d14d2c5ee9c34127631d54ff023f4d2c2b6236.