Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1255973004: Add a handler for enabled/disabling assist. (Closed)

Created:
5 years, 5 months ago by Ted C
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a handler for enabled/disabling assist. This disables assist if showing an incognito tab or if in a tab switcher showing icognito tabs. BUG=497258 Committed: https://crrev.com/a2147a35be3bd7ab2e3ff3a0aaf498d5f190f5b9 Cr-Commit-Position: refs/heads/master@{#340382}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -8 lines) Patch
A chrome/android/java/src/org/chromium/chrome/browser/AssistStatusHandler.java View 1 chunk +105 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 4 chunks +28 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 1 5 chunks +33 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Ted C
PTAL
5 years, 5 months ago (2015-07-24 18:49:04 UTC) #2
David Trainor- moved to gerrit
lgtm. Looks like it covers accessibility overview mode too, but I'd just check it to ...
5 years, 5 months ago (2015-07-24 19:22:17 UTC) #3
sgurun-gerrit only
On 2015/07/24 19:22:17, David Trainor wrote: > lgtm. Looks like it covers accessibility overview mode ...
5 years, 5 months ago (2015-07-24 19:53:08 UTC) #4
Ted C
tested in accessibility and it works there as well.
5 years, 5 months ago (2015-07-24 20:33:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255973004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255973004/1
5 years, 5 months ago (2015-07-24 20:36:07 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/49179) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 5 months ago (2015-07-24 20:38:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255973004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255973004/20001
5 years, 5 months ago (2015-07-24 23:46:52 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-25 00:25:31 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-25 00:26:35 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a2147a35be3bd7ab2e3ff3a0aaf498d5f190f5b9
Cr-Commit-Position: refs/heads/master@{#340382}

Powered by Google App Engine
This is Rietveld 408576698