Use ui::GestureConfiguration to disable tap suppression in Android WebView

Use ui::GestureConfiguration to disable tap suppression in Android WebView

BUG=514783

[jdduke (slow), 2015-07-31 21:10:31]

jdduke@chromium.org changed reviewers:
+ jdduke@chromium.org

[jdduke (slow), 2015-07-31 21:10:31]

https://codereview.chromium.org/1262403005/diff/20001/android_webview/native/...
File android_webview/native/aw_contents.cc (right):

https://codereview.chromium.org/1262403005/diff/20001/android_webview/native/...
android_webview/native/aw_contents.cc:309:
ui::GestureConfiguration::GetInstance()
What about doing it in AwMainDelegate::BasicStartupComplete?

[hush (inactive), 2015-07-31 21:48:25]

https://codereview.chromium.org/1262403005/diff/20001/android_webview/native/...
File android_webview/native/aw_contents.cc (right):

https://codereview.chromium.org/1262403005/diff/20001/android_webview/native/...
android_webview/native/aw_contents.cc:309:
ui::GestureConfiguration::GetInstance()
On 2015/07/31 21:10:31, jdduke wrote:
> What about doing it in AwMainDelegate::BasicStartupComplete?

ah yes. That works too. I don't have strong preference over one another. I will
just put it over there, which is invoked only once (instead of invoking for each
webview)

[hush (inactive), 2015-07-31 23:00:21]

hush@chromium.org changed reviewers:
+ boliu@chromium.org

[hush (inactive), 2015-07-31 23:00:45]

Bo, PTAL

[hush (inactive), 2015-07-31 23:01:24]

On 2015/07/31 23:00:45, hush wrote:
> Bo, PTAL

This CL depends on https://codereview.chromium.org/1267693004/

[boliu, 2015-07-31 23:03:46]

On 2015/07/31 23:01:24, hush wrote:
> On 2015/07/31 23:00:45, hush wrote:
> > Bo, PTAL
> 
> This CL depends on https://codereview.chromium.org/1267693004/

new DEPS will require ui owner approval anyway, why not merge them?

[jdduke (slow), 2015-07-31 23:04:28]

https://codereview.chromium.org/1262403005/diff/40001/android_webview/lib/mai...
File android_webview/lib/main/aw_main_delegate.cc (right):

https://codereview.chromium.org/1262403005/diff/40001/android_webview/lib/mai...
android_webview/lib/main/aw_main_delegate.cc:65:
->set_fling_touchscreen_tap_suppression_enabled(false);
This might be worth a comment, something about tap suppression interacting
poorly when the embedder prevents fling updates or something like that.

[jdduke (slow), 2015-07-31 23:09:04]

On 2015/07/31 23:04:28, jdduke wrote:
>
https://codereview.chromium.org/1262403005/diff/40001/android_webview/lib/mai...
> File android_webview/lib/main/aw_main_delegate.cc (right):
> 
>
https://codereview.chromium.org/1262403005/diff/40001/android_webview/lib/mai...
> android_webview/lib/main/aw_main_delegate.cc:65:
> ->set_fling_touchscreen_tap_suppression_enabled(false);
> This might be worth a comment, something about tap suppression interacting
> poorly when the embedder prevents fling updates or something like that.

I can merge this in, just want to make sure this is OK with android_webview
owners.

[boliu, 2015-07-31 23:12:20]

On 2015/07/31 23:09:04, jdduke wrote:
> On 2015/07/31 23:04:28, jdduke wrote:
> >
>
https://codereview.chromium.org/1262403005/diff/40001/android_webview/lib/mai...
> > File android_webview/lib/main/aw_main_delegate.cc (right):
> > 
> >
>
https://codereview.chromium.org/1262403005/diff/40001/android_webview/lib/mai...
> > android_webview/lib/main/aw_main_delegate.cc:65:
> > ->set_fling_touchscreen_tap_suppression_enabled(false);
> > This might be worth a comment, something about tap suppression interacting
> > poorly when the embedder prevents fling updates or something like that.
> 
> I can merge this in, just want to make sure this is OK with android_webview
> owners.

It's one line. Looks fine :)

[hush (inactive), 2015-07-31 23:13:33]

https://codereview.chromium.org/1262403005/diff/40001/android_webview/lib/mai...
File android_webview/lib/main/aw_main_delegate.cc (right):

https://codereview.chromium.org/1262403005/diff/40001/android_webview/lib/mai...
android_webview/lib/main/aw_main_delegate.cc:65:
->set_fling_touchscreen_tap_suppression_enabled(false);
On 2015/07/31 23:04:28, jdduke wrote:
> This might be worth a comment, something about tap suppression interacting
> poorly when the embedder prevents fling updates or something like that.

Done.