Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2474)

Unified Diff: android_webview/lib/main/aw_main_delegate.cc

Issue 1262403005: Use ui::GestureConfiguration to disable tap suppression in Android WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add a comment Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/lib/DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/lib/main/aw_main_delegate.cc
diff --git a/android_webview/lib/main/aw_main_delegate.cc b/android_webview/lib/main/aw_main_delegate.cc
index f94d49882278a31fa284d475f7bd9dfc664198be..5ad0c0978b4b2ed1fe353ec6f01af9611515c703 100644
--- a/android_webview/lib/main/aw_main_delegate.cc
+++ b/android_webview/lib/main/aw_main_delegate.cc
@@ -35,6 +35,7 @@
#include "gpu/command_buffer/client/gl_in_process_context.h"
#include "gpu/command_buffer/service/gpu_switches.h"
#include "media/base/media_switches.h"
+#include "ui/events/gesture_detection/gesture_configuration.h"
namespace android_webview {
@@ -60,6 +61,12 @@ bool AwMainDelegate::BasicStartupComplete(int* exit_code) {
BrowserViewRenderer::CalculateTileMemoryPolicy();
+ // Android WebView apps can override WebView#computeScroll to achieve custom
+ // scroll/fling. As a result, the animations may not be ticked. This will
+ // confuse the tap suppression controller. So just disable it for WebView.
+ ui::GestureConfiguration::GetInstance()
+ ->set_fling_touchscreen_tap_suppression_enabled(false);
+
base::CommandLine* cl = base::CommandLine::ForCurrentProcess();
cl->AppendSwitch(switches::kUseIpcCommandBuffer);
cl->AppendSwitch(cc::switches::kEnableBeginFrameScheduling);
« no previous file with comments | « android_webview/lib/DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698