Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: pkg/compiler/lib/src/resolution/send_structure.dart

Issue 1262363003: Handle super index SendSet operations. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Update comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/resolution/send_structure.dart
diff --git a/pkg/compiler/lib/src/resolution/send_structure.dart b/pkg/compiler/lib/src/resolution/send_structure.dart
index e4aaee39742e66568ede7cec41c85c4a105a4cf7..b5134a2eb544fc4e33edfbc0759fa90c37bbd0f6 100644
--- a/pkg/compiler/lib/src/resolution/send_structure.dart
+++ b/pkg/compiler/lib/src/resolution/send_structure.dart
@@ -835,7 +835,7 @@ class NotStructure<R, A> implements SendStructure<R, A> {
node,
node.receiver,
arg);
- default:
+ default:
// This is not a valid case.
break;
}
@@ -876,6 +876,12 @@ class UnaryStructure<R, A> implements SendStructure<R, A> {
operator,
semantics.element,
arg);
+ case AccessKind.INVALID:
+ return visitor.errorInvalidUnary(
+ node,
+ operator,
+ semantics.element,
+ arg);
default:
// This is not a valid case.
break;
@@ -931,6 +937,12 @@ class IndexStructure<R, A> implements SendStructure<R, A> {
semantics.element,
node.arguments.single,
arg);
+ case AccessKind.INVALID:
+ return visitor.errorInvalidIndex(
+ node,
+ semantics.element,
+ node.arguments.single,
+ arg);
default:
// This is not a valid case.
break;
@@ -961,6 +973,12 @@ class EqualsStructure<R, A> implements SendStructure<R, A> {
semantics.element,
node.arguments.single,
arg);
+ case AccessKind.INVALID:
+ return visitor.errorInvalidEquals(
+ node,
+ semantics.element,
+ node.arguments.single,
+ arg);
default:
// This is not a valid case.
break;
@@ -993,6 +1011,12 @@ class NotEqualsStructure<R, A> implements SendStructure<R, A> {
semantics.element,
node.arguments.single,
arg);
+ case AccessKind.INVALID:
+ return visitor.errorInvalidNotEquals(
+ node,
+ semantics.element,
+ node.arguments.single,
+ arg);
default:
// This is not a valid case.
break;
@@ -1038,6 +1062,13 @@ class BinaryStructure<R, A> implements SendStructure<R, A> {
operator,
node.arguments.single,
arg);
+ case AccessKind.INVALID:
+ return visitor.errorInvalidBinary(
+ node,
+ semantics.element,
+ operator,
+ node.arguments.single,
+ arg);
default:
// This is not a valid case.
break;
@@ -1102,6 +1133,13 @@ class IndexSetStructure<R, A> implements SendStructure<R, A> {
node.arguments.first,
node.arguments.tail.head,
arg);
+ case AccessKind.INVALID:
+ return visitor.errorInvalidIndexSet(
+ node,
+ semantics.element,
+ node.arguments.first,
+ node.arguments.tail.head,
+ arg);
default:
// This is not a valid case.
break;
@@ -1151,6 +1189,13 @@ class IndexPrefixStructure<R, A> implements SendStructure<R, A> {
node.arguments.single,
operator,
arg);
+ case AccessKind.INVALID:
+ return visitor.errorInvalidIndexPrefix(
+ node,
+ semantics.element,
+ node.arguments.single,
+ operator,
+ arg);
case AccessKind.COMPOUND:
CompoundAccessSemantics compoundSemantics = semantics;
switch (compoundSemantics.compoundAccessKind) {
@@ -1230,6 +1275,13 @@ class IndexPostfixStructure<R, A> implements SendStructure<R, A> {
node.arguments.single,
operator,
arg);
+ case AccessKind.INVALID:
+ return visitor.errorInvalidIndexPostfix(
+ node,
+ semantics.element,
+ node.arguments.single,
+ operator,
+ arg);
case AccessKind.COMPOUND:
CompoundAccessSemantics compoundSemantics = semantics;
switch (compoundSemantics.compoundAccessKind) {
@@ -1658,6 +1710,14 @@ class CompoundIndexSetStructure<R, A> implements SendStructure<R, A> {
operator,
node.arguments.tail.head,
arg);
+ case AccessKind.INVALID:
+ return visitor.errorInvalidCompoundIndexSet(
+ node,
+ semantics.element,
+ node.arguments.first,
+ operator,
+ node.arguments.tail.head,
+ arg);
case AccessKind.COMPOUND:
CompoundAccessSemantics compoundSemantics = semantics;
switch (compoundSemantics.compoundAccessKind) {

Powered by Google App Engine
This is Rietveld 408576698