Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: pkg/compiler/lib/src/resolution/semantic_visitor.dart

Issue 1262363003: Handle super index SendSet operations. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Update comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/resolution/semantic_visitor.dart
diff --git a/pkg/compiler/lib/src/resolution/semantic_visitor.dart b/pkg/compiler/lib/src/resolution/semantic_visitor.dart
index 342cf333713a23ab4f81577009f2331607ea8555..d09316ac0f43e8f1c638281801afd3aac3d38f23 100644
--- a/pkg/compiler/lib/src/resolution/semantic_visitor.dart
+++ b/pkg/compiler/lib/src/resolution/semantic_visitor.dart
@@ -4136,6 +4136,111 @@ abstract class SemanticSendVisitor<R, A> {
Node rhs,
A arg);
+ /// Unary operation with [operator] on an invalid expression.
+ ///
+ /// For instance
+ /// m() => ~super;
floitsch 2015/07/31 12:30:37 why is this invalid? Code samples should be inten
Johnni Winther 2015/07/31 13:38:29 It is top level. Changing the examples to be stati
Johnni Winther 2015/07/31 13:38:29 Done.
+ ///
+ R errorInvalidUnary(
+ Send node,
+ UnaryOperator operator,
+ ErroneousElement error,
+ A arg);
+
+ /// Equals operation on an invalid left expression.
+ ///
+ /// For instance
+ /// m() => super == null;
+ ///
+ R errorInvalidEquals(
+ Send node,
+ ErroneousElement error,
+ Node right,
+ A arg);
+
+ /// Not equals operation on an invalid left expression.
+ ///
+ /// For instance
+ /// m() => super != null;
+ ///
+ R errorInvalidNotEquals(
+ Send node,
+ ErroneousElement error,
+ Node right,
+ A arg);
+
+ /// Binary operation with [operator] on an invalid left expression.
+ ///
+ /// For instance
+ /// m() => super + 0;
+ ///
+ R errorInvalidBinary(
+ Send node,
+ ErroneousElement error,
+ BinaryOperator operator,
+ Node right,
+ A arg);
+
+ /// Index operation on an invalid expression.
+ ///
+ /// For instance
+ /// m() => super[0];
+ ///
+ R errorInvalidIndex(
+ Send node,
+ ErroneousElement error,
+ Node index,
+ A arg);
+
+ /// Index set operation on an invalid expression.
+ ///
+ /// For instance
+ /// m() => super[0] = 42;
+ ///
+ R errorInvalidIndexSet(
+ Send node,
+ ErroneousElement error,
+ Node index,
+ Node rhs,
+ A arg);
+
+ /// Compound index set operation on an invalid expression.
+ ///
+ /// For instance
+ /// m() => super[0] += 42;
+ ///
+ R errorInvalidCompoundIndexSet(
+ Send node,
+ ErroneousElement error,
+ Node index,
+ AssignmentOperator operator,
+ Node rhs,
+ A arg);
+
+ /// Prefix index operation on an invalid expression.
+ ///
+ /// For instance
+ /// m() => --super[0];
+ ///
+ R errorInvalidIndexPrefix(
+ Send node,
+ ErroneousElement error,
+ Node index,
+ IncDecOperator operator,
+ A arg);
+
+ /// Postfix index operation on an invalid expression.
+ ///
+ /// For instance
+ /// m() => super[0++;
+ ///
+ R errorInvalidIndexPostfix(
+ Send node,
+ ErroneousElement error,
+ Node index,
+ IncDecOperator operator,
+ A arg);
+
/// Access of library through a deferred [prefix].
///
/// For instance

Powered by Google App Engine
This is Rietveld 408576698