[turbofan]: Add better encapsulation to LinkageLocation

[turbofan]: Add better encapsulation to LinkageLocation

Add factory methods for different types of LinkageLocations, and ensure that
accesses to the underlying data in the location are classified by type and
funneled through explicit accessors.

Also change the representation of LinkageLocation to use a BitField rather
than using a reserved section of the integer range.

Committed: https://crrev.com/3c9f69d399384a5ad095b1f35cb6804d3d4062f6
Cr-Commit-Position: refs/heads/master@{#29938}

[danno, 2015-07-30 11:42:42]

danno@chromium.org changed reviewers:
+ bmeurer@chromium.org, titzer@chromium.org

[danno, 2015-07-30 11:42:54]

PTAL

[Benedikt Meurer, 2015-07-30 11:46:11]

LGTM with nit. Love it, thanks :-)

https://codereview.chromium.org/1262343002/diff/40001/src/compiler/linkage.h
File src/compiler/linkage.h (right):

https://codereview.chromium.org/1262343002/diff/40001/src/compiler/linkage.h#...
src/compiler/linkage.h:61: class IsRegisterField : public BitField<bool, 0, 1>
{};
Nit: please use an enum instead of bool here.

[danno, 2015-07-30 14:06:18]

The CQ bit was checked by danno@chromium.org

[danno, 2015-07-30 14:06:19]

Feedback addressed... landing.

https://codereview.chromium.org/1262343002/diff/40001/src/compiler/linkage.h
File src/compiler/linkage.h (right):

https://codereview.chromium.org/1262343002/diff/40001/src/compiler/linkage.h#...
src/compiler/linkage.h:61: class IsRegisterField : public BitField<bool, 0, 1>
{};
On 2015/07/30 at 11:46:11, Benedikt Meurer wrote:
> Nit: please use an enum instead of bool here.

Done

[danno, 2015-07-30 14:06:19]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1262343002/#ps80001
(title: "Review feedback")

[commit-bot: I haz the power, 2015-07-30 14:06:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1262343002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1262343002/80001

[commit-bot: I haz the power, 2015-07-30 14:07:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-30 14:07:08]

Try jobs failed on following builders:
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)

[danno, 2015-07-30 14:10:45]

The CQ bit was checked by danno@chromium.org

[danno, 2015-07-30 14:10:46]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1262343002/#ps100001
(title: "Fix build")

[commit-bot: I haz the power, 2015-07-30 14:10:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1262343002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1262343002/100001

[commit-bot: I haz the power, 2015-07-30 14:14:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-30 14:14:37]

Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)

[danno, 2015-07-30 14:36:59]

The CQ bit was checked by danno@chromium.org

[danno, 2015-07-30 14:37:00]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1262343002/#ps160001
(title: "Really fix it this time")

[commit-bot: I haz the power, 2015-07-30 14:37:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1262343002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1262343002/160001

[commit-bot: I haz the power, 2015-07-30 14:52:18]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2015-07-30 14:52:51]

Patchset 9 (id:??) landed as
https://crrev.com/3c9f69d399384a5ad095b1f35cb6804d3d4062f6
Cr-Commit-Position: refs/heads/master@{#29938}