Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1262263003: Add DartPackage annotation to all mojo_services mojoms (Closed)

Created:
5 years, 4 months ago by Cutch
Modified:
5 years, 4 months ago
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add DartPackage annotation to all mojo_services mojoms - The mojo_services package now vends all of the mojoms it owns. - Fixed up breakage due to import path changes. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f9ad1a73c5fffa1fff0e365eb9e9b6732d80c14a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -18 lines) Patch
M mojo/dart/embedder/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/dart/embedder/io/mojo_patch.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M mojo/dart/embedder/packages.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M mojo/public/tools/dart_pkg.py View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/services/accessibility/public/interfaces/accessibility.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/asset_bundle/public/interfaces/asset_bundle.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/authenticating_url_loader_interceptor/public/interfaces/authenticating_url_loader_interceptor_meta_factory.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/authentication/public/interfaces/authentication.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/camera_roll/public/interfaces/camera_roll.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/clipboard/public/interfaces/clipboard.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/content_handler/public/interfaces/content_handler.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/device_info/public/interfaces/device_info.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/files/public/interfaces/directory.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/files/public/interfaces/file.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/files/public/interfaces/files.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/files/public/interfaces/types.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/geometry/public/interfaces/geometry.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/gpu/public/interfaces/command_buffer.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/gpu/public/interfaces/context_provider.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/gpu/public/interfaces/gpu.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/gpu/public/interfaces/gpu_capabilities.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/gpu/public/interfaces/viewport_parameter_listener.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/http_server/public/interfaces/http_request.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/http_server/public/interfaces/http_response.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/http_server/public/interfaces/http_server.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/http_server/public/interfaces/http_server_factory.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/icu_data/public/interfaces/icu_data.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/input_events/public/interfaces/input_event_constants.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/input_events/public/interfaces/input_events.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/input_events/public/interfaces/input_key_codes.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/keyboard/public/interfaces/keyboard.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/location/public/interfaces/geocoder.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/location/public/interfaces/location.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/location/public/interfaces/location_service.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/native_viewport/public/interfaces/native_viewport.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/navigation/public/interfaces/navigation.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/public/interfaces/cookie_store.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/public/interfaces/host_resolver.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/public/interfaces/http_connection.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/public/interfaces/http_message.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/public/interfaces/http_server.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/public/interfaces/net_address.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/public/interfaces/network_service.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/public/interfaces/tcp_bound_socket.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/public/interfaces/tcp_connected_socket.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/public/interfaces/tcp_server_socket.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/public/interfaces/udp_socket.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/public/interfaces/url_loader.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/public/interfaces/url_loader_interceptor.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/public/interfaces/web_socket.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/nfc/public/interfaces/nfc.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/notifications/public/interfaces/notifications.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/prediction/public/interfaces/prediction.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/sensors/public/interfaces/sensors.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/service_registry/public/interfaces/service_registry.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/speech_recognizer/public/interfaces/speech_recognizer.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/surfaces/public/interfaces/display.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/surfaces/public/interfaces/quads.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/surfaces/public/interfaces/surface_id.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/surfaces/public/interfaces/surfaces.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/terminal/public/interfaces/terminal.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/terminal/public/interfaces/terminal_client.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/tracing/public/interfaces/tracing.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/url_response_disk_cache/public/interfaces/url_response_disk_cache.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/view_manager/public/interfaces/animations.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/view_manager/public/interfaces/view_manager.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/view_manager/public/interfaces/view_manager_constants.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/window_manager/public/interfaces/window_manager.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/window_manager/public/interfaces/window_manager_internal.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M services/url_response_disk_cache/url_response_disk_cache_entry.mojom View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Cutch
5 years, 4 months ago (2015-07-30 16:04:22 UTC) #2
eseidel
lgtm
5 years, 4 months ago (2015-07-30 16:06:10 UTC) #3
Cutch
Committed patchset #1 (id:1) manually as f9ad1a73c5fffa1fff0e365eb9e9b6732d80c14a (presubmit successful).
5 years, 4 months ago (2015-07-30 16:06:43 UTC) #4
abarth-chromium
5 years, 4 months ago (2015-07-30 16:16:50 UTC) #6
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698