Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: mojo/public/tools/dart_pkg.py

Issue 1262263003: Add DartPackage annotation to all mojo_services mojoms (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/dart/embedder/packages.dart ('k') | mojo/services/accessibility/public/interfaces/accessibility.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/tools/dart_pkg.py
diff --git a/mojo/public/tools/dart_pkg.py b/mojo/public/tools/dart_pkg.py
index db347dd0e86a4b9c75a1dc8b45fbc39436a1cf8f..28cc8ae0566f86fa7429f666634021023d0c8eff 100755
--- a/mojo/public/tools/dart_pkg.py
+++ b/mojo/public/tools/dart_pkg.py
@@ -173,6 +173,7 @@ def analyze_entrypoints(dart_sdk, package_root, entrypoints):
try:
subprocess.check_call(cmd)
except subprocess.CalledProcessError as e:
+ print('Failed analyzing %s' % entrypoints)
return e.returncode
return 0
@@ -289,8 +290,9 @@ def main():
# Copy generated mojom.dart files.
# HACK(johnmccutchan): This entire step will be removed once all DartPackage
- # annotations are in place. Until then, skip doing this for the mojo package.
- if args.package_name != 'mojo':
+ # annotations are in place. Until then, skip doing this for the mojo and
+ # mojo_services packages.
+ if (args.package_name != 'mojo') and (args.package_name != 'mojo_services'):
generated_mojom_lib_path = os.path.join(args.gen_directory, "mojom/lib")
for mojom_source_path in args.mojom_sources:
path = mojom_path(mojom_source_path)
« no previous file with comments | « mojo/dart/embedder/packages.dart ('k') | mojo/services/accessibility/public/interfaces/accessibility.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698