chrome-search: should not be display-isolated

chrome/renderer/chrome_content_renderer_client.cc

Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index b7814592f2b28dab52ffb6676546c2535c18f6f7..efadf3f5bd1ef748b9d0b327cec93e8174a71244 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -248,7 +248,8 @@ void ChromeContentRendererClient::RenderThreadStarted() {
   WebSecurityPolicy::registerURLSchemeAsDisplayIsolated(chrome_ui_scheme);
 
   WebString chrome_search_scheme(ASCIIToUTF16(chrome::kChromeSearchScheme));
-  WebSecurityPolicy::registerURLSchemeAsDisplayIsolated(chrome_search_scheme);
+  if (!command_line->HasSwitch(switches::kInstantProcess))
+    WebSecurityPolicy::registerURLSchemeAsDisplayIsolated(chrome_search_scheme);

[Shishir, 2013/03/20 21:35:52]

As sreeram pointed out, we should just block all chrome-search access for pages
out of the instant process.

[dhollowa, 2013/03/20 22:15:08]

We're effectively doing that on the browser-side already.  Are you thinking of a
specific mechanism to do this on the renderer side (besides the one here that
is)?

[Shishir, 2013/03/20 22:20:49]

One way I can think of doing that on the renderer side is blocking calls in
WillSendRequest in the same file. You can do what the extension system does for
requests where there is no access - rewrite the URL. We can do that in a
separate CL if you prefer.

[dhollowa, 2013/03/20 23:12:24]

But, correct me if I'm wrong, adding a similar check to WillSendRequest() would
be redundant with the restrictions in place here with
registerURLSchemeAsDisplayIsolated().

If extensions were display-isolated they wouldn't need the WillSendRequest()
logic.

 
   WebString dev_tools_scheme(ASCIIToUTF16(chrome::kChromeDevToolsScheme));
   WebSecurityPolicy::registerURLSchemeAsDisplayIsolated(dev_tools_scheme);