chrome-search: should not be display-isolated

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include <string>
 #include <vector>
 
 #include "base/command_line.h"
@@ skipping 230 matching lines @@
     thread->GetChannel()->set_outgoing_message_filter(LoadExternalIPCFuzzer());
   }
   // chrome:, chrome-search:, chrome-devtools:, and chrome-internal: pages
   // should not be accessible by normal content, and should also be unable to
   // script anything but themselves (to help limit the damage that a corrupt
   // page could cause).
   WebString chrome_ui_scheme(ASCIIToUTF16(chrome::kChromeUIScheme));
   WebSecurityPolicy::registerURLSchemeAsDisplayIsolated(chrome_ui_scheme);
 
   WebString chrome_search_scheme(ASCIIToUTF16(chrome::kChromeSearchScheme));
-  WebSecurityPolicy::registerURLSchemeAsDisplayIsolated(chrome_search_scheme);
+  if (!command_line->HasSwitch(switches::kInstantProcess))
+    WebSecurityPolicy::registerURLSchemeAsDisplayIsolated(chrome_search_scheme);

[Shishir, 2013/03/20 21:35:52]

As sreeram pointed out, we should just block all chrome-search access for pages
out of the instant process.

[dhollowa, 2013/03/20 22:15:08]

We're effectively doing that on the browser-side already.  Are you thinking of a
specific mechanism to do this on the renderer side (besides the one here that
is)?

[Shishir, 2013/03/20 22:20:49]

One way I can think of doing that on the renderer side is blocking calls in
WillSendRequest in the same file. You can do what the extension system does for
requests where there is no access - rewrite the URL. We can do that in a
separate CL if you prefer.

[dhollowa, 2013/03/20 23:12:24]

But, correct me if I'm wrong, adding a similar check to WillSendRequest() would
be redundant with the restrictions in place here with
registerURLSchemeAsDisplayIsolated().

If extensions were display-isolated they wouldn't need the WillSendRequest()
logic.

 
   WebString dev_tools_scheme(ASCIIToUTF16(chrome::kChromeDevToolsScheme));
   WebSecurityPolicy::registerURLSchemeAsDisplayIsolated(dev_tools_scheme);
 
   WebString internal_scheme(ASCIIToUTF16(chrome::kChromeInternalScheme));
   WebSecurityPolicy::registerURLSchemeAsDisplayIsolated(internal_scheme);
 
 #if defined(OS_CHROMEOS)
   WebString drive_scheme(ASCIIToUTF16(chrome::kDriveScheme));
   WebSecurityPolicy::registerURLSchemeAsLocal(drive_scheme);
@@ skipping 865 matching lines @@
     return false;
 
   if (container->element().shadowHost().isNull())
     return false;
 
   return container->element().shadowHost().tagName().equals(
       WebString::fromUTF8(kWebViewTagName));
 }
 
 }  // namespace chrome