Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1261953003: clang/win: Build chromium_code with -Wunused-function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | media/audio/win/audio_device_listener_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 1db19c1b557bcd173941ef307c8b07df14a40870..6f24175aee79bd53fd418222077795241ec2a363 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -849,7 +849,6 @@ if (is_win) {
"-Wno-microsoft", # http://crbug.com/505296
"-Wno-switch", # http://crbug.com/505308
"-Wno-unknown-pragmas", # http://crbug.com/505314
- "-Wno-unused-function", # http://crbug.com/505316
"-Wno-unused-value", # http://crbug.com/505318
]
}
@@ -1042,6 +1041,10 @@ config("no_chromium_code") {
# libraries as required. http://crbug.com/505301.
"-Wno-overloaded-virtual",
+ # TODO(thakis): Move this suppression into individual third-party
+ # libraries as required. http://crbug.com/505316.
+ "-Wno-unused-function",
+
# Lots of third-party libraries have unused variables. Instead of
# suppressing them individually, we just blanket suppress them here.
"-Wno-unused-variable",
« no previous file with comments | « build/common.gypi ('k') | media/audio/win/audio_device_listener_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698