Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 1261953002: Re-enable precompiled headers in GN on Windows. (Closed)

Created:
5 years, 4 months ago by brettw
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable precompiled headers in GN on Windows. This fixes the incremental build error by disabling the warning (see the code for a detailed description). It adds conditions for goma and official builds which match GYP. Committed: https://crrev.com/48d359b13c0f60e444280afc03df8dfeb8ebe41d Cr-Commit-Position: refs/heads/master@{#340769}

Patch Set 1 #

Patch Set 2 : more flags #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M build/config/BUILD.gn View 1 3 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
brettw
5 years, 4 months ago (2015-07-28 19:56:42 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261953002/1
5 years, 4 months ago (2015-07-28 19:57:56 UTC) #4
Dirk Pranke
lgtm
5 years, 4 months ago (2015-07-28 20:38:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261953002/20001
5 years, 4 months ago (2015-07-28 20:47:29 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-28 21:26:55 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 21:27:31 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/48d359b13c0f60e444280afc03df8dfeb8ebe41d
Cr-Commit-Position: refs/heads/master@{#340769}

Powered by Google App Engine
This is Rietveld 408576698