Fix system unit tests on Android.

Fix system unit tests on Android.

tmpfile() fails on android because this is hardcoding /tmp which is not
writeable.

R=viettrungluu@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/b89685b36e0c13ffbb25a8b76829197b7cbcaa6b

[viettrungluu, 2015-07-28 18:17:10]

Sigh, not only does MSVS not provide a working tmpfile(), neither does
Android.... :-(

https://codereview.chromium.org/1261903002/diff/1/mojo/edk/embedder/platform_...
File mojo/edk/embedder/platform_channel_pair_posix_unittest.cc (right):

https://codereview.chromium.org/1261903002/diff/1/mojo/edk/embedder/platform_...
mojo/edk/embedder/platform_channel_pair_posix_unittest.cc:18: #include
"base/files/file_path.h"
Could you please put this under the ifdef also?

https://codereview.chromium.org/1261903002/diff/1/mojo/edk/embedder/platform_...
mojo/edk/embedder/platform_channel_pair_posix_unittest.cc:29: #if
defined(OS_ANDROID)
You should explicitly include build/build_config.h for OS_ANDROID.

https://codereview.chromium.org/1261903002/diff/1/mojo/edk/embedder/platform_...
mojo/edk/embedder/platform_channel_pair_posix_unittest.cc:53: return fdopen(fd,
"w");
This should be "wb+" according to the C standard (or equivalently "w+",
according to POSIX).

https://codereview.chromium.org/1261903002/diff/1/mojo/edk/embedder/platform_...
mojo/edk/embedder/platform_channel_pair_posix_unittest.cc:53: return fdopen(fd,
"w");
You should unlink() the file too.

[viettrungluu, 2015-07-29 00:36:20]

(Also, for efficiency, LGTM w/indicated changes.)

[qsr, 2015-07-29 08:37:31]

https://codereview.chromium.org/1261903002/diff/1/mojo/edk/embedder/platform_...
File mojo/edk/embedder/platform_channel_pair_posix_unittest.cc (right):

https://codereview.chromium.org/1261903002/diff/1/mojo/edk/embedder/platform_...
mojo/edk/embedder/platform_channel_pair_posix_unittest.cc:18: #include
"base/files/file_path.h"
On 2015/07/28 18:17:09, viettrungluu wrote:
> Could you please put this under the ifdef also?

Done.

https://codereview.chromium.org/1261903002/diff/1/mojo/edk/embedder/platform_...
mojo/edk/embedder/platform_channel_pair_posix_unittest.cc:29: #if
defined(OS_ANDROID)
On 2015/07/28 18:17:10, viettrungluu wrote:
> You should explicitly include build/build_config.h for OS_ANDROID.

Done.

https://codereview.chromium.org/1261903002/diff/1/mojo/edk/embedder/platform_...
mojo/edk/embedder/platform_channel_pair_posix_unittest.cc:53: return fdopen(fd,
"w");
On 2015/07/28 18:17:10, viettrungluu wrote:
> You should unlink() the file too.

Done.

https://codereview.chromium.org/1261903002/diff/1/mojo/edk/embedder/platform_...
mojo/edk/embedder/platform_channel_pair_posix_unittest.cc:53: return fdopen(fd,
"w");
On 2015/07/28 18:17:10, viettrungluu wrote:
> This should be "wb+" according to the C standard (or equivalently "w+",
> according to POSIX).

Done.

[qsr, 2015-07-29 08:37:37]

Committed patchset #2 (id:20001) manually as
b89685b36e0c13ffbb25a8b76829197b7cbcaa6b (presubmit successful).