Fix system unit tests on Android.

mojo/edk/embedder/platform_channel_pair_posix_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/edk/embedder/platform_channel_pair.h"
 
 #include <errno.h>
 #include <poll.h>
 #include <signal.h>
 #include <stdio.h>
 #include <sys/socket.h>
 #include <sys/types.h>
 #include <sys/uio.h>
 #include <unistd.h>
 
 #include <deque>
 
+#include "base/files/file_path.h"

[viettrungluu, 2015/07/28 18:17:09]

Could you please put this under the ifdef also?

[qsr, 2015/07/29 08:37:31]

Done.

 #include "base/files/scoped_file.h"
 #include "base/logging.h"
 #include "mojo/edk/embedder/platform_channel_utils_posix.h"
 #include "mojo/edk/embedder/platform_handle.h"
 #include "mojo/edk/embedder/platform_handle_vector.h"
 #include "mojo/edk/embedder/scoped_platform_handle.h"
 #include "mojo/edk/test/test_utils.h"
 #include "mojo/public/cpp/system/macros.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
+#if defined(OS_ANDROID)

[viettrungluu, 2015/07/28 18:17:10]

You should explicitly include build/build_config.h for OS_ANDROID.

[qsr, 2015/07/29 08:37:31]

Done.

+#include "base/android/path_utils.h"
+#endif
+
 namespace mojo {
 namespace embedder {
 namespace {
 
 void WaitReadable(PlatformHandle h) {
   struct pollfd pfds = {};
   pfds.fd = h.fd;
   pfds.events = POLLIN;
   CHECK_EQ(poll(&pfds, 1, -1), 1);
 }
 
+FILE* NewTmpFile() {
+#if defined(OS_ANDROID)
+  base::FilePath tmpdir;
+  if (!base::android::GetCacheDirectory(&tmpdir))
+    return nullptr;
+  std::string templ = tmpdir.Append("XXXXXXXX").value();
+  int fd = mkstemp(const_cast<char*>(templ.c_str()));
+  if (fd == -1)
+    return nullptr;
+  return fdopen(fd, "w");

[viettrungluu, 2015/07/28 18:17:10]

You should unlink() the file too.

[viettrungluu, 2015/07/28 18:17:10]

This should be "wb+" according to the C standard (or equivalently "w+",
according to POSIX).

[qsr, 2015/07/29 08:37:31]

Done.

[qsr, 2015/07/29 08:37:31]

Done.

+#else
+  return tmpfile();
+#endif
+}
+
 class PlatformChannelPairPosixTest : public testing::Test {
  public:
   PlatformChannelPairPosixTest() {}
   ~PlatformChannelPairPosixTest() override {}
 
   void SetUp() override {
     // Make sure |SIGPIPE| isn't being ignored.
     struct sigaction action = {};
     action.sa_handler = SIG_DFL;
     ASSERT_EQ(0, sigaction(SIGPIPE, &action, &old_action_));
@@ skipping 88 matching lines @@
 #else
   const size_t kNumHandlesToSend = kPlatformChannelMaxNumHandles;
 #endif
 
   for (size_t i = 1; i < kNumHandlesToSend; i++) {
     // Make |i| files, with the j-th file consisting of j copies of the digit
     // |c|.
     const char c = '0' + (i % 10);
     ScopedPlatformHandleVectorPtr platform_handles(new PlatformHandleVector);
     for (size_t j = 1; j <= i; j++) {
-      base::ScopedFILE fp(tmpfile());
+      base::ScopedFILE fp(NewTmpFile());
       ASSERT_TRUE(fp);
       ASSERT_EQ(j, fwrite(std::string(j, c).data(), 1, j, fp.get()));
       platform_handles->push_back(
           test::PlatformHandleFromFILE(fp.Pass()).release());
       ASSERT_TRUE(platform_handles->back().is_valid());
     }
 
     // Send the FDs (+ "hello").
     struct iovec iov = {const_cast<char*>(kHello), sizeof(kHello)};
     // We assume that the |sendmsg()| actually sends all the data.
@@ skipping 30 matching lines @@
 TEST_F(PlatformChannelPairPosixTest, AppendReceivedFDs) {
   static const char kHello[] = "hello";
 
   PlatformChannelPair channel_pair;
   ScopedPlatformHandle server_handle = channel_pair.PassServerHandle().Pass();
   ScopedPlatformHandle client_handle = channel_pair.PassClientHandle().Pass();
 
   const std::string file_contents("hello world");
 
   {
-    base::ScopedFILE fp(tmpfile());
+    base::ScopedFILE fp(NewTmpFile());
     ASSERT_TRUE(fp);
     ASSERT_EQ(file_contents.size(),
               fwrite(file_contents.data(), 1, file_contents.size(), fp.get()));
     ScopedPlatformHandleVectorPtr platform_handles(new PlatformHandleVector);
     platform_handles->push_back(
         test::PlatformHandleFromFILE(fp.Pass()).release());
     ASSERT_TRUE(platform_handles->back().is_valid());
 
     // Send the FD (+ "hello").
     struct iovec iov = {const_cast<char*>(kHello), sizeof(kHello)};
@@ skipping 29 matching lines @@
     char read_buf[100];
     size_t bytes_read = fread(read_buf, 1, sizeof(read_buf), fp.get());
     EXPECT_EQ(file_contents.size(), bytes_read);
     EXPECT_EQ(file_contents, std::string(read_buf, bytes_read));
   }
 }
 
 }  // namespace
 }  // namespace embedder
 }  // namespace mojo