Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1261863002: [runtime] DeclareGlobals and DeclareLookupSlot don't need context parameters. (Closed)

Created:
5 years, 4 months ago by Benedikt Meurer
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] DeclareGlobals and DeclareLookupSlot don't need context parameters. All runtime function get a context anyway, which is the same as the explicit one in case of DeclareGlobals and DeclareLookupSlot. So we can remove the additional parameter there. As an additional bonus, improve the runtime interface to DeclareLookupSlot. R=yangguo@chromium.org Committed: https://crrev.com/5edd18fc2e78c29594c667b9cfae68c293862d14 Cr-Commit-Position: refs/heads/master@{#29923}

Patch Set 1 #

Patch Set 2 : Also do the optimization for DeclareLookupSlot. #

Patch Set 3 : Improve DeclareLookupSlot runtime interface. #

Patch Set 4 : Fix x64 typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -125 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 3 chunks +9 lines, -12 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 3 chunks +10 lines, -11 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 4 chunks +6 lines, -10 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 3 chunks +9 lines, -12 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 3 chunks +9 lines, -12 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 2 3 3 chunks +10 lines, -12 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 4 chunks +6 lines, -10 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 2 4 chunks +6 lines, -10 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 2 3 chunks +32 lines, -14 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Benedikt Meurer
5 years, 4 months ago (2015-07-28 10:42:16 UTC) #1
Benedikt Meurer
Hey Yang, This is some initial cleanup for DeclareGlobals. More to come. Please take a ...
5 years, 4 months ago (2015-07-28 10:43:53 UTC) #2
Yang
On 2015/07/28 10:43:53, Benedikt Meurer wrote: > Hey Yang, > > This is some initial ...
5 years, 4 months ago (2015-07-28 11:02:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261863002/1
5 years, 4 months ago (2015-07-28 11:02:34 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261863002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261863002/40001
5 years, 4 months ago (2015-07-28 13:46:44 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/8168)
5 years, 4 months ago (2015-07-29 14:14:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261863002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261863002/60001
5 years, 4 months ago (2015-07-30 08:58:32 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 4 months ago (2015-07-30 09:29:46 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 09:30:12 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5edd18fc2e78c29594c667b9cfae68c293862d14
Cr-Commit-Position: refs/heads/master@{#29923}

Powered by Google App Engine
This is Rietveld 408576698