src/x64/lithium-codegen-x64.cc - Issue 1261863002: [runtime] DeclareGlobals and DeclareLookupSlot don't need context parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.cc

Issue 1261863002: [runtime] DeclareGlobals and DeclareLookupSlot don't need context parameters. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix x64 typo. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/lithium-codegen-x64.cc

diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc

index fcb470d0283737bc27128236a1c7f8fc7cdda045..dea70b5c7ab4b3615e073b65731cb8f86a1a9854 100644

--- a/src/x64/lithium-codegen-x64.cc

+++ b/src/x64/lithium-codegen-x64.cc

@@ -3494,10 +3494,9 @@ void LCodeGen::DoContext(LContext* instr) {

void LCodeGen::DoDeclareGlobals(LDeclareGlobals* instr) {

DCHECK(ToRegister(instr->context()).is(rsi));

- __ Push(rsi); // The context is the first argument.

__ Push(instr->hydrogen()->pairs());

__ Push(Smi::FromInt(instr->hydrogen()->flags()));

- CallRuntime(Runtime::kDeclareGlobals, 3, instr);

+ CallRuntime(Runtime::kDeclareGlobals, 2, instr);

}

« no previous file with comments | « src/runtime/runtime-scopes.cc ('k') | src/x87/lithium-codegen-x87.cc » ('j') | no next file with comments »