Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1261653002: Move SelectionState out of LayoutObject and into Line Layout API (Closed)

Created:
5 years, 4 months ago by pilgrim_google
Modified:
5 years, 3 months ago
CC:
blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-rendering, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move SelectionState out of LayoutObject and into Line Layout API This enum is used everywhere, in and out of the new API. Originally this was going to be part of my EllipsisBox CL, but I broke it out after it touched 20+ files. BUG=499321 Committed: https://crrev.com/da4123d210051a38ff1256458e5f01a849d8a703 git-svn-id: svn://svn.chromium.org/blink/trunk@199593 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Total comments: 2

Patch Set 2 : 2 legit 5ever #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -80 lines) Patch
M Source/core/core.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/LayoutBlockFlow.cpp View 1 2 chunks +7 lines, -6 lines 0 comments Download
M Source/core/layout/LayoutBlockFlowLine.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/layout/LayoutObject.h View 1 2 chunks +1 line, -8 lines 0 comments Download
A Source/core/layout/api/SelectionState.h View 1 1 chunk +20 lines, -0 lines 0 comments Download
M Source/core/layout/line/EllipsisBox.h View 3 chunks +5 lines, -4 lines 0 comments Download
M Source/core/layout/line/InlineBox.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/layout/line/InlineBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/line/InlineFlowBox.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/layout/line/InlineFlowBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/line/InlineTextBox.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/layout/line/InlineTextBox.cpp View 4 chunks +19 lines, -19 lines 0 comments Download
M Source/core/layout/line/RootInlineBox.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/layout/line/RootInlineBox.cpp View 6 chunks +20 lines, -20 lines 0 comments Download
M Source/core/page/TouchAdjustment.cpp View 3 chunks +7 lines, -6 lines 0 comments Download
M Source/core/paint/EllipsisBoxPainter.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/paint/InlineFlowBoxPainter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/paint/InlineTextBoxPainter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/ListMarkerPainter.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M Source/core/paint/ReplacedPainter.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/paint/SVGInlineTextBoxPainter.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/paint/SVGRootInlineBoxPainter.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
pilgrim_google
5 years, 4 months ago (2015-07-27 14:24:52 UTC) #2
leviw_travelin_and_unemployed
LGTM. Some description nits: It's currently two sentence fragments. "ELlipsisBox"
5 years, 4 months ago (2015-07-27 23:48:59 UTC) #3
jsbell
https://codereview.chromium.org/1261653002/diff/1/Source/core/layout/api/SelectionState.h File Source/core/layout/api/SelectionState.h (right): https://codereview.chromium.org/1261653002/diff/1/Source/core/layout/api/SelectionState.h#newcode1 Source/core/layout/api/SelectionState.h:1: // Copyright 2014 The Chromium Authors. All rights reserved. ...
5 years, 4 months ago (2015-07-28 00:27:48 UTC) #4
leviw_travelin_and_unemployed
http://imgur.com/Ce9h2iy
5 years, 4 months ago (2015-07-28 00:35:47 UTC) #5
leviw_travelin_and_unemployed
On 2015/07/28 at 00:35:47, leviw wrote: > http://imgur.com/Ce9h2iy I add: 2 legit 2 nit!
5 years, 4 months ago (2015-07-28 00:36:19 UTC) #6
jsbell
On 2015/07/28 00:36:19, leviw wrote: > On 2015/07/28 at 00:35:47, leviw wrote: > > http://imgur.com/Ce9h2iy ...
5 years, 4 months ago (2015-07-28 17:19:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261653002/20001
5 years, 4 months ago (2015-07-28 17:33:25 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=199593
5 years, 4 months ago (2015-07-28 18:32:18 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 11:51:14 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/da4123d210051a38ff1256458e5f01a849d8a703

Powered by Google App Engine
This is Rietveld 408576698