Source/core/layout/LayoutBlockFlowLine.cpp - Issue 1261653002: Move SelectionState out of LayoutObject and into Line Layout API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutBlockFlowLine.cpp

Issue 1261653002: Move SelectionState out of LayoutObject and into Line Layout API (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: 2 legit 5ever Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/LayoutBlockFlowLine.cpp

diff --git a/Source/core/layout/LayoutBlockFlowLine.cpp b/Source/core/layout/LayoutBlockFlowLine.cpp

index 1adb85f642620f242e08320e00f510ef835cdffd..29bd228b016eaf7b03641a15d9a372a10ab7b8d5 100644

--- a/Source/core/layout/LayoutBlockFlowLine.cpp

+++ b/Source/core/layout/LayoutBlockFlowLine.cpp

@@ -33,6 +33,7 @@

#include "core/layout/TextRunConstructor.h"

#include "core/layout/VerticalPositionCache.h"

#include "core/layout/api/LineLayoutItem.h"

+#include "core/layout/api/SelectionState.h"

#include "core/layout/line/BreakingContextInlineHeaders.h"

#include "core/layout/line/GlyphOverflow.h"

#include "core/layout/line/LayoutTextInfo.h"

@@ -220,7 +221,7 @@ RootInlineBox* LayoutBlockFlow::constructLine(BidiRunList<BidiRun>& bidiRuns, co

if (!box)

continue;

- if (!rootHasSelectedChildren && box->layoutObject().selectionState() != LayoutObject::SelectionNone)

+ if (!rootHasSelectedChildren && box->layoutObject().selectionState() != SelectionNone)

rootHasSelectedChildren = true;

// If we have no parent box yet, or if the run is not simply a sibling,

« no previous file with comments | « Source/core/layout/LayoutBlockFlow.cpp ('k') | Source/core/layout/LayoutObject.h » ('j') | no next file with comments »