Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 1261433007: PPC: VectorICs: refactoring to eliminate "for queries only" vector ic mode. (Closed)

Created:
5 years, 4 months ago by MTBrandyberry
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: VectorICs: refactoring to eliminate "for queries only" vector ic mode. Port 1a5751f9b3ca682fadb6fce8202dda2db5b017c6 Original commit message: Since we need the notion of a dummy vector ic, we can use that to avoid a special case of the IC constructor. Also, consolidate the two dummy ICs into one. R=mvstanton@chromium.org, michael_dawson@ca.ibm.com, jyan@ca.ibm.com, joransiu@ca.ibm.com BUG= Committed: https://crrev.com/de7e8a8c6df64b4db4f4f9d472d5db3aee497b70 Cr-Commit-Position: refs/heads/master@{#29959}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M src/ic/ppc/ic-ppc.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
MTBrandyberry
5 years, 4 months ago (2015-07-31 18:51:27 UTC) #1
JoranSiu
lgtm
5 years, 4 months ago (2015-07-31 19:00:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261433007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261433007/1
5 years, 4 months ago (2015-07-31 19:03:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-31 19:26:43 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/de7e8a8c6df64b4db4f4f9d472d5db3aee497b70 Cr-Commit-Position: refs/heads/master@{#29959}
5 years, 4 months ago (2015-07-31 19:27:13 UTC) #6
john.yan
5 years, 4 months ago (2015-07-31 20:29:32 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698