Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1261353003: gpu: Add ANGLE commit to program cache hash. (Closed)

Created:
5 years, 4 months ago by Jamie Madill
Modified:
5 years, 4 months ago
Reviewers:
David Yen, vmiura, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Add ANGLE commit to program cache hash. ANGLE rejects program binaries compiled from a different ANGLE, because the program format can change, and other incompatibilities. Add the commit id to the cache hash so the cache layer can skip trying to compile these shaders. This change should mostly affect developers who are testing Chrome and modifying ANGLE between compiles. BUG=510151 Committed: https://crrev.com/dc26192a317d9511ce983fd4b26b1130fe25761a Cr-Commit-Position: refs/heads/master@{#341713}

Patch Set 1 #

Patch Set 2 : Add commit id target to command bufer deps #

Patch Set 3 : Update BUILD.gn as well #

Patch Set 4 : Fix BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M gpu/command_buffer/service/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/program_cache.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M gpu/command_buffer_service.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
Jamie Madill
PTAL - I tested this manually. Didn't seem as simple to add a test in ...
5 years, 4 months ago (2015-07-31 14:19:54 UTC) #2
Jamie Madill
piman@chromium.org: PTAL, added a change to the gypi.
5 years, 4 months ago (2015-07-31 21:06:45 UTC) #4
Jamie Madill
Review pings!
5 years, 4 months ago (2015-08-03 14:29:04 UTC) #5
David Yen
LGTM (Although I'm not an owner)
5 years, 4 months ago (2015-08-03 17:20:53 UTC) #6
vmiura
lgtm
5 years, 4 months ago (2015-08-03 17:51:02 UTC) #7
piman
lgtm
5 years, 4 months ago (2015-08-03 22:09:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261353003/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261353003/50001
5 years, 4 months ago (2015-08-03 22:26:31 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/94288)
5 years, 4 months ago (2015-08-03 23:45:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261353003/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261353003/50001
5 years, 4 months ago (2015-08-04 12:39:56 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:50001)
5 years, 4 months ago (2015-08-04 12:44:43 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 12:45:28 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/dc26192a317d9511ce983fd4b26b1130fe25761a
Cr-Commit-Position: refs/heads/master@{#341713}

Powered by Google App Engine
This is Rietveld 408576698