Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: chrome/browser/manifest/manifest_icon_downloader.cc

Issue 1261143004: Implement manifest icon downloader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/manifest/manifest_icon_downloader.cc
diff --git a/chrome/browser/manifest/manifest_icon_downloader.cc b/chrome/browser/manifest/manifest_icon_downloader.cc
new file mode 100644
index 0000000000000000000000000000000000000000..5746a52507484788fb3f40bb0cc1b441f78f29fb
--- /dev/null
+++ b/chrome/browser/manifest/manifest_icon_downloader.cc
@@ -0,0 +1,131 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/manifest/manifest_icon_downloader.h"
+
+#include <limits>
+
+#include "chrome/browser/manifest/manifest_icon_selector.h"
+#include "content/public/browser/browser_thread.h"
+#include "content/public/browser/web_contents.h"
+#include "skia/ext/image_operations.h"
+#include "ui/gfx/screen.h"
+
+bool ManifestIconDownloader::Download(
+ content::WebContents* web_contents,
+ const GURL& icon_url,
+ int ideal_icon_size_in_dp,
+ const ManifestIconDownloader::IconFetchCallback& callback) {
+ if (!web_contents || !icon_url.is_valid())
+ return false;
+
+ const gfx::Screen* screen =
+ gfx::Screen::GetScreenFor(web_contents->GetNativeView());
+
+ const float device_scale_factor =
+ screen->GetPrimaryDisplay().device_scale_factor();
+ const float ideal_icon_size_in_px =
+ ideal_icon_size_in_dp * device_scale_factor;
+
+ const int minimum_scale_factor = std::max(
+ static_cast<int>(floor(device_scale_factor - 1)), 1);
+ const float minimum_icon_size_in_px =
+ ideal_icon_size_in_dp * minimum_scale_factor;
+
+ web_contents->DownloadImage(
+ icon_url,
+ false, // is_favicon
+ 0, // max_bitmap_size - 0 means no maximum size.
+ false, // bypass_cache
+ base::Bind(&ManifestIconDownloader::OnIconFetched,
+ ideal_icon_size_in_px,
+ minimum_icon_size_in_px,
+ callback));
+ return true;
+}
+
+void ManifestIconDownloader::OnIconFetched(
+ int ideal_icon_size_in_px,
+ int minimum_icon_size_in_px,
+ const ManifestIconDownloader::IconFetchCallback& callback,
+ int id,
+ int http_status_code,
+ const GURL& url,
+ const std::vector<SkBitmap>& bitmaps,
+ const std::vector<gfx::Size>& sizes) {
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+
+ const int closest_index = FindClosestBitmapIndex(
+ ideal_icon_size_in_px, minimum_icon_size_in_px, bitmaps);
+
+ if (closest_index == -1) {
+ callback.Run(SkBitmap());
+ return;
+ }
+
+ const SkBitmap& chosen = bitmaps[closest_index];
+
+ // Only scale if we need to scale down. For scaling up we will let the system
+ // handle that when it is required to display it. This saves space in the
+ // webapp storage system as well.
+ if (chosen.height() > ideal_icon_size_in_px) {
+ content::BrowserThread::PostTask(
+ content::BrowserThread::IO,
+ FROM_HERE,
+ base::Bind(&ManifestIconDownloader::ScaleIcon,
+ ideal_icon_size_in_px,
+ chosen,
+ callback));
+ return;
+ }
+
+ callback.Run(chosen);
+}
+
+void ManifestIconDownloader::ScaleIcon(
+ int ideal_icon_size_in_px,
+ const SkBitmap& bitmap,
+ const ManifestIconDownloader::IconFetchCallback& callback) {
+ DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
+
+ const SkBitmap& scaled = skia::ImageOperations::Resize(
+ bitmap,
+ skia::ImageOperations::RESIZE_BEST,
+ ideal_icon_size_in_px,
+ ideal_icon_size_in_px);
+
+ content::BrowserThread::PostTask(
+ content::BrowserThread::UI,
+ FROM_HERE,
+ base::Bind(callback, scaled));
+}
+
+int ManifestIconDownloader::FindClosestBitmapIndex(
+ int ideal_icon_size_in_px,
+ int minimum_icon_size_in_px,
+ const std::vector<SkBitmap>& bitmaps) {
+ int best_index = -1;
+ int best_delta = std::numeric_limits<int>::min();
+ const int max_negative_delta =
+ minimum_icon_size_in_px - ideal_icon_size_in_px;
+
+ for (size_t i = 0; i < bitmaps.size(); ++i) {
+ if (bitmaps[i].height() != bitmaps[i].width())
+ continue;
+
+ int delta = bitmaps[i].width() - ideal_icon_size_in_px;
+ if (delta == 0)
+ return i;
+
+ if (best_delta > 0 && delta < 0)
+ continue;
+
+ if ((best_delta > 0 && delta < best_delta) ||
+ (best_delta < 0 && delta > best_delta && delta >= max_negative_delta)) {
+ best_index = i;
+ best_delta = delta;
+ }
+ }
+ return best_index;
+}
« no previous file with comments | « chrome/browser/manifest/manifest_icon_downloader.h ('k') | chrome/browser/manifest/manifest_icon_downloader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698