Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5155)

Unified Diff: chrome/browser/manifest/manifest_icon_downloader_unittest.cc

Issue 1261143004: Implement manifest icon downloader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/manifest/manifest_icon_downloader.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/manifest/manifest_icon_downloader_unittest.cc
diff --git a/chrome/browser/manifest/manifest_icon_downloader_unittest.cc b/chrome/browser/manifest/manifest_icon_downloader_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..624223ee46f54c1b9571fcbd29f6eae72772ea56
--- /dev/null
+++ b/chrome/browser/manifest/manifest_icon_downloader_unittest.cc
@@ -0,0 +1,123 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/manifest/manifest_icon_downloader.h"
+
+#include <string>
+#include <vector>
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+class ManifestIconDownloaderTest : public testing::Test {
+ protected:
+ ManifestIconDownloaderTest() = default;
+ ~ManifestIconDownloaderTest() override = default;
+
+ int FindBitmap(const int ideal_icon_size_in_px,
+ const int minimum_icon_size_in_px,
+ const std::vector<SkBitmap>& bitmaps) {
+ return ManifestIconDownloader::FindClosestBitmapIndex(
+ ideal_icon_size_in_px, minimum_icon_size_in_px, bitmaps);
+ }
+
+ SkBitmap CreateDummyBitmap(int width, int height) {
+ SkBitmap bitmap;
+ bitmap.allocN32Pixels(width, height);
+ bitmap.setImmutable();
+ return bitmap;
+ }
+
+ DISALLOW_COPY_AND_ASSIGN(ManifestIconDownloaderTest);
+};
+
+TEST_F(ManifestIconDownloaderTest, NoIcons) {
+ ASSERT_EQ(-1, FindBitmap(0, 0, std::vector<SkBitmap>()));
+}
+
+TEST_F(ManifestIconDownloaderTest, ExactIsChosen) {
+ std::vector<SkBitmap> bitmaps;
+ bitmaps.push_back(CreateDummyBitmap(10, 10));
+
+ ASSERT_EQ(0, FindBitmap(10, 0, bitmaps));
+}
+
+TEST_F(ManifestIconDownloaderTest, BiggerIsChosen) {
+ std::vector<SkBitmap> bitmaps;
+ bitmaps.push_back(CreateDummyBitmap(20, 20));
+
+ ASSERT_EQ(0, FindBitmap(10, 0, bitmaps));
+}
+
+TEST_F(ManifestIconDownloaderTest, SmallerBelowMinimumIsIgnored) {
+ std::vector<SkBitmap> bitmaps;
+ bitmaps.push_back(CreateDummyBitmap(10, 10));
+
+ ASSERT_EQ(-1, FindBitmap(20, 15, bitmaps));
+}
+
+TEST_F(ManifestIconDownloaderTest, SmallerAboveMinimumIsChosen) {
+ std::vector<SkBitmap> bitmaps;
+ bitmaps.push_back(CreateDummyBitmap(15, 15));
+
+ ASSERT_EQ(0, FindBitmap(20, 15, bitmaps));
+}
+
+TEST_F(ManifestIconDownloaderTest, ExactIsPreferredOverBigger) {
+ std::vector<SkBitmap> bitmaps;
+ bitmaps.push_back(CreateDummyBitmap(20, 20));
+ bitmaps.push_back(CreateDummyBitmap(10, 10));
+
+ ASSERT_EQ(1, FindBitmap(10, 0, bitmaps));
+}
+
+TEST_F(ManifestIconDownloaderTest, ExactIsPreferredOverSmaller) {
+ std::vector<SkBitmap> bitmaps;
+ bitmaps.push_back(CreateDummyBitmap(20, 20));
+ bitmaps.push_back(CreateDummyBitmap(10, 10));
+
+ ASSERT_EQ(0, FindBitmap(20, 0, bitmaps));
+}
+
+TEST_F(ManifestIconDownloaderTest, BiggerIsPreferredOverCloserSmaller) {
+ std::vector<SkBitmap> bitmaps;
+ bitmaps.push_back(CreateDummyBitmap(20, 20));
+ bitmaps.push_back(CreateDummyBitmap(10, 10));
+
+ ASSERT_EQ(0, FindBitmap(11, 0, bitmaps));
+}
+
+TEST_F(ManifestIconDownloaderTest, ClosestToExactIsChosen) {
+ std::vector<SkBitmap> bitmaps;
+ bitmaps.push_back(CreateDummyBitmap(25, 25));
+ bitmaps.push_back(CreateDummyBitmap(20, 20));
+
+ ASSERT_EQ(1, FindBitmap(10, 0, bitmaps));
+}
+
+TEST_F(ManifestIconDownloaderTest, MixedReturnsBiggestClosest) {
+ std::vector<SkBitmap> bitmaps;
+ bitmaps.push_back(CreateDummyBitmap(10, 10));
+ bitmaps.push_back(CreateDummyBitmap(8, 8));
+ bitmaps.push_back(CreateDummyBitmap(6, 6));
+
+ ASSERT_EQ(0, FindBitmap(9, 0, bitmaps));
+}
+
+TEST_F(ManifestIconDownloaderTest, MixedCanReturnMiddle) {
+ std::vector<SkBitmap> bitmaps;
+ bitmaps.push_back(CreateDummyBitmap(10, 10));
+ bitmaps.push_back(CreateDummyBitmap(8, 8));
+ bitmaps.push_back(CreateDummyBitmap(6, 6));
+
+ ASSERT_EQ(1, FindBitmap(7, 0, bitmaps));
+}
+
+TEST_F(ManifestIconDownloaderTest, NonSquareIsIgnored) {
+ std::vector<SkBitmap> bitmaps;
+ bitmaps.push_back(CreateDummyBitmap(15, 10));
+ bitmaps.push_back(CreateDummyBitmap(10, 15));
+
+ ASSERT_EQ(-1, FindBitmap(15, 0, bitmaps));
+ ASSERT_EQ(-1, FindBitmap(10, 0, bitmaps));
+}
« no previous file with comments | « chrome/browser/manifest/manifest_icon_downloader.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698