Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3162)

Unified Diff: chrome/browser/android/shortcut_data_fetcher.h

Issue 1261143004: Implement manifest icon downloader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/shortcut_data_fetcher.h
diff --git a/chrome/browser/android/shortcut_data_fetcher.h b/chrome/browser/android/shortcut_data_fetcher.h
index f1e8593786ac521b81878c42203740ae0e3fa3db..5d67da67471ee9c68c8b6ee2011131a39c8e679e 100644
--- a/chrome/browser/android/shortcut_data_fetcher.h
+++ b/chrome/browser/android/shortcut_data_fetcher.h
@@ -23,6 +23,7 @@ class Message;
}
class GURL;
+class ManifestIconDownloader;
// Aysnchronously fetches and processes data needed to create a shortcut for an
// Android Home screen launcher.
@@ -81,14 +82,6 @@ class ShortcutDataFetcher
void CreateLauncherIcon(
const favicon_base::FaviconRawBitmapResult& bitmap_result);
- // Callback run after an attempt to download manifest icon has been made. May
- // kick off the download of a favicon if it failed.
- void OnManifestIconFetched(int id,
- int http_status_code,
- const GURL& url,
- const std::vector<SkBitmap>& bitmaps,
- const std::vector<gfx::Size>& sizes);
-
// Notifies the observer that the shortcut data is all available.
void NotifyObserver(const SkBitmap& icon);
@@ -104,6 +97,8 @@ class ShortcutDataFetcher
SkBitmap shortcut_icon_;
base::CancelableTaskTracker favicon_task_tracker_;
+ scoped_ptr<ManifestIconDownloader> icon_downloader_;
+
const int preferred_icon_size_in_px_;
static const int kPreferredIconSizeInDp;

Powered by Google App Engine
This is Rietveld 408576698