chrome/browser/android/banners/app_banner_data_fetcher_android.cc - Issue 1261143004: Implement manifest icon downloader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/banners/app_banner_data_fetcher_android.cc

Issue 1261143004: Implement manifest icon downloader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/banners/app_banner_data_fetcher_android.cc

diff --git a/chrome/browser/android/banners/app_banner_data_fetcher_android.cc b/chrome/browser/android/banners/app_banner_data_fetcher_android.cc

index cb96a9e7c3b9e1e5a70e52c080e879e2378ee94c..89da6d378f9e8b009bd6335d730c76fa349dcda2 100644

--- a/chrome/browser/android/banners/app_banner_data_fetcher_android.cc

+++ b/chrome/browser/android/banners/app_banner_data_fetcher_android.cc

@@ -32,10 +32,11 @@ bool AppBannerDataFetcherAndroid::ContinueFetching(

const std::string& app_package,

base::android::ScopedJavaLocalRef<jobject> app_data,

const GURL& image_url) {

+ content::WebContents* web_contents = GetWebContents();

set_app_title(app_title);

native_app_package_ = app_package;

native_app_data_.Reset(app_data);

- return FetchIcon(image_url);

+ return FetchAppIcon(web_contents, image_url);

mlamouri (slow - plz ping) 2015/08/21 09:27:11 nit: instead do: return FetchAppIcon(GetWebConte

}

std::string AppBannerDataFetcherAndroid::GetAppIdentifier() {