Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: chrome/browser/android/banners/app_banner_data_fetcher_android.cc

Issue 1261143004: Implement manifest icon downloader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix issues raised in comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_data_fetcher_android.cc
diff --git a/chrome/browser/android/banners/app_banner_data_fetcher_android.cc b/chrome/browser/android/banners/app_banner_data_fetcher_android.cc
index cb96a9e7c3b9e1e5a70e52c080e879e2378ee94c..3be63521169a008e98c0d99cf582cfa3ca65f253 100644
--- a/chrome/browser/android/banners/app_banner_data_fetcher_android.cc
+++ b/chrome/browser/android/banners/app_banner_data_fetcher_android.cc
@@ -35,7 +35,11 @@ bool AppBannerDataFetcherAndroid::ContinueFetching(
set_app_title(app_title);
native_app_package_ = app_package;
native_app_data_.Reset(app_data);
- return FetchIcon(image_url);
+
+ content::WebContents* web_contents = GetWebContents();
+ DCHECK(web_contents);
mlamouri (slow - plz ping) 2015/08/05 08:20:16 nit: I would move the DCHECK() inside FetchAppIcon
Lalit Maganti 2015/08/05 14:47:13 Got rid of web contents all together as I don't ev
+
+ return FetchAppIcon(web_contents, image_url);
}
std::string AppBannerDataFetcherAndroid::GetAppIdentifier() {

Powered by Google App Engine
This is Rietveld 408576698