Implement manifest icon downloader

chrome/browser/android/banners/app_banner_data_fetcher_android.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/banners/app_banner_data_fetcher_android.h"
 
 #include "chrome/browser/android/banners/app_banner_infobar_delegate_android.h"
 #include "chrome/browser/banners/app_banner_metrics.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/ui/android/infobars/app_banner_infobar_android.h"
@@ skipping 17 matching lines @@
 }
 
 bool AppBannerDataFetcherAndroid::ContinueFetching(
     const base::string16& app_title,
     const std::string& app_package,
     base::android::ScopedJavaLocalRef<jobject> app_data,
     const GURL& image_url) {
   set_app_title(app_title);
   native_app_package_ = app_package;
   native_app_data_.Reset(app_data);
-  return FetchIcon(image_url);
+
+  content::WebContents* web_contents = GetWebContents();
+  DCHECK(web_contents);

[mlamouri (slow - plz ping), 2015/08/05 08:20:16]

nit: I would move the DCHECK() inside FetchAppIcon().

IOW, I would do:
return FetchAppIcon(GetWebContents(), image_url);

[Lalit Maganti, 2015/08/05 14:47:13]

Got rid of web contents all together as I don't even need it.

+
+  return FetchAppIcon(web_contents, image_url);
 }
 
 std::string AppBannerDataFetcherAndroid::GetAppIdentifier() {
   return native_app_data_.is_null()
       ? AppBannerDataFetcher::GetAppIdentifier() : native_app_package_;
 }
 
 void AppBannerDataFetcherAndroid::ShowBanner(const SkBitmap* icon,
                                              const base::string16& title) {
   content::WebContents* web_contents = GetWebContents();
@@ skipping 20 matching lines @@
     if (infobar) {
       RecordDidShowBanner("AppBanner.NativeApp.Shown");
       TrackDisplayEvent(DISPLAY_EVENT_NATIVE_APP_BANNER_CREATED);
     }
   }
   InfoBarService::FromWebContents(web_contents)
       ->AddInfoBar(make_scoped_ptr(infobar));
 }
 
 }  // namespace banners