Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: content/browser/renderer_host/media/audio_input_renderer_host.cc

Issue 12611030: Remove unused parameter to OnError() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/audio_input_renderer_host.cc
diff --git a/content/browser/renderer_host/media/audio_input_renderer_host.cc b/content/browser/renderer_host/media/audio_input_renderer_host.cc
index 08f8086d48adbc7b34ec641ae77300fb01d98b6d..8167c3e008fbc9a740835eaf440c1e1988c1c0a3 100644
--- a/content/browser/renderer_host/media/audio_input_renderer_host.cc
+++ b/content/browser/renderer_host/media/audio_input_renderer_host.cc
@@ -94,13 +94,12 @@ void AudioInputRendererHost::OnRecording(
}
void AudioInputRendererHost::OnError(
scherkus (not reviewing) 2013/03/21 17:37:24 nit: this looks like it can fit on one line (i.e.,
jrummell 2013/03/21 18:17:31 Done.
- media::AudioInputController* controller,
- int error_code) {
+ media::AudioInputController* controller) {
BrowserThread::PostTask(
BrowserThread::IO,
FROM_HERE,
base::Bind(&AudioInputRendererHost::DoHandleError,
- this, make_scoped_refptr(controller), error_code));
+ this, make_scoped_refptr(controller)));
scherkus (not reviewing) 2013/03/21 17:37:24 nit: can you fix indentation here? it should line
jrummell 2013/03/21 18:17:31 Done.
}
void AudioInputRendererHost::OnData(media::AudioInputController* controller,
@@ -171,10 +170,7 @@ void AudioInputRendererHost::DoSendRecordingMessage(
}
void AudioInputRendererHost::DoHandleError(
- media::AudioInputController* controller,
- int error_code) {
- DLOG(WARNING) << "AudioInputRendererHost::DoHandleError(error_code="
- << error_code << ")";
+ media::AudioInputController* controller) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
AudioEntry* entry = LookupByController(controller);

Powered by Google App Engine
This is Rietveld 408576698